Re: [PATCH] D22555: [Clang] Fix RHEL 6 build and other Include What You Use warnings

Eugene.Zelenko abandoned this revision. Eugene.Zelenko added a comment. Committed as fix for build failure after llvm/ADT/DenseMap.h in r278583. Repository: rL LLVM https://reviews.llvm.org/D22555 ___ cfe-commits mailing list cfe-commits@lists.ll

Re: [PATCH] D22555: [Clang] Fix RHEL 6 build and other Include What You Use warnings

I'm not necessarily disagreeing, I'm saying that if I understand correctly, there are two unrelated changes (one is a build fix, and the other is a "good practice" kind of change). > On Jul 19, 2016, at 6:43 PM, Eugene Zelenko wrote: > > Eugene.Zelenko added a comment. > > But all of them are

Re: [PATCH] D22555: [Clang] Fix RHEL 6 build and other Include What You Use warnings

Eugene.Zelenko added a comment. But all of them are used in code. I don't see a reason to save lines :-) Repository: rL LLVM https://reviews.llvm.org/D22555 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mai

Re: [PATCH] D22555: [Clang] Fix RHEL 6 build and other Include What You Use warnings

mehdi_amini added inline comments. Comment at: lib/Basic/FileManager.cpp:35 @@ -29,2 +34,3 @@ #include +#include That's a lot of includes though. Ok for the climits, but the other should be a separate patch I think. Repository: rL LLVM https://reviews.l

[PATCH] D22555: [Clang] Fix RHEL 6 build and other Include What You Use warnings

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: hans, mehdi_amini. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. Build was broken because of missing climits where PATH_MAX is defined. Repository: rL LLVM ht