bruno closed this revision.
bruno added a comment.
Thanks Manman, Committed r276020
https://reviews.llvm.org/D22183
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
manmanren accepted this revision.
manmanren added a comment.
This revision is now accepted and ready to land.
LGTM.
Manman
Comment at: lib/Parse/ParseObjc.cpp:3489
@@ -3478,3 +3488,3 @@
-// Parse the ellipsis that designates this as a pack expansion.
-SourceLocati
bruno added a comment.
Ping!
https://reviews.llvm.org/D22183
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno updated this revision to Diff 64162.
bruno added a comment.
Thanks for the review Manman, I found a much better approach. Updated the patch
to reflect that!
https://reviews.llvm.org/D22183
Files:
lib/Parse/ParseObjc.cpp
test/SemaObjC/objc-array-literal.m
test/SemaObjC/objc-dictiona
manmanren added a comment.
> Before this patch, the testcase added used to take
> 5s to compile!!! A bit more elaborate NSDictionary literal with some
> undeclared enums would make the compiler take 22min to run, followed by a
> crash.
--> this is a big improvement!
A few notes from discu
bruno created this revision.
bruno added reviewers: manmanren, doug.gregor.
bruno added a subscriber: cfe-commits.
Calls to TransformExpr for NSDictionary elements (keys and values) in
TransformObjCDictionaryLiteral might fail to obtain TypoCorrections. This is OK,
but the early exits with ExprErr
