Re: [PATCH] D22146: clang-format: [JS] Sort imports case insensitive.

2016-07-09 Thread Martin Probst via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL274977: clang-format: [JS] Sort imports case insensitive. (authored by mprobst). Changed prior to commit: http://reviews.llvm.org/D22146?vs=63271&id=63391#toc Repository: rL LLVM http://reviews.llvm

Re: [PATCH] D22146: clang-format: [JS] Sort imports case insensitive.

2016-07-08 Thread Daniel Jasper via cfe-commits
djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Looks good. http://reviews.llvm.org/D22146 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

Re: [PATCH] D22146: clang-format: [JS] Sort imports case insensitive.

2016-07-08 Thread Martin Probst via cfe-commits
mprobst updated this revision to Diff 63271. mprobst added a comment. - clang-format: [JS] support trailing commas in imports. http://reviews.llvm.org/D22146 Files: lib/Format/SortJavaScriptImports.cpp unittests/Format/SortImportsTestJS.cpp Index: unittests/Format/SortImportsTestJS.cpp ===

[PATCH] D22146: clang-format: [JS] Sort imports case insensitive.

2016-07-08 Thread Martin Probst via cfe-commits
mprobst created this revision. mprobst added a reviewer: djasper. mprobst added a subscriber: cfe-commits. Herald added a subscriber: klimek. ASCII case sorting does not help finding imported symbols quickly, and it is common to have e.g. class Foo and function fooFactory exported/imported from