This revision was automatically updated to reflect the committed changes.
Closed by commit rL275387: [clang-rename] exit code-related bugfix and code
cleanup (authored by d0k).
Changed prior to commit:
http://reviews.llvm.org/D22091?vs=63931&id=63943#toc
Repository:
rL LLVM
http://reviews.l
bkramer added a comment.
on it ...
http://reviews.llvm.org/D22091
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh added a comment.
In http://reviews.llvm.org/D22091#483834, @omtcyf0 wrote:
> Thanks, @alexfh!
>
> Can you please land it?
It's not easy to do from the phone ;) Please ask someone else (Ben?).
http://reviews.llvm.org/D22091
___
cfe-commits
omtcyf0 marked an inline comment as done.
omtcyf0 added a comment.
Thanks, @alexfh!
Can you please land it?
http://reviews.llvm.org/D22091
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
omtcyf0 updated this revision to Diff 63931.
http://reviews.llvm.org/D22091
Files:
clang-rename/RenamingAction.cpp
clang-rename/USRLocFinder.cpp
clang-rename/USRLocFinder.h
clang-rename/tool/ClangRename.cpp
test/clang-rename/NoNewName.cpp
Index: test/clang-rename/NoNewName.cpp
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG with one comment.
Comment at: clang-rename/USRLocFinder.cpp:73-76
@@ -73,3 +72,6 @@
SourceLocation Location = Initializer->getSourceLocation();
- String
omtcyf0 added a comment.
Does it look good now?
http://reviews.llvm.org/D22091
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
omtcyf0 updated this revision to Diff 63463.
omtcyf0 added a comment.
Add new test, which ensures clang-rename failure if new name is not passed.
http://reviews.llvm.org/D22091
Files:
clang-rename/RenamingAction.cpp
clang-rename/USRLocFinder.cpp
clang-rename/USRLocFinder.h
clang-rename/
omtcyf0 marked an inline comment as done.
Comment at: clang-rename/USRLocFinder.cpp:73-75
@@ -73,3 +72,5 @@
SourceLocation Location = Initializer->getSourceLocation();
- StringRef TokenName =
Lexer::getSourceText(CharSourceRange::getTokenRange(Location),
Cont
omtcyf0 updated this revision to Diff 63418.
http://reviews.llvm.org/D22091
Files:
clang-rename/RenamingAction.cpp
clang-rename/USRLocFinder.cpp
clang-rename/USRLocFinder.h
clang-rename/tool/ClangRename.cpp
Index: clang-rename/tool/ClangRename.cpp
alexfh added inline comments.
Comment at: clang-rename/USRLocFinder.cpp:63
@@ -62,3 +62,3 @@
const ASTContext &Context = ConstructorDecl->getASTContext();
-for (clang::CXXConstructorDecl::init_const_iterator it =
ConstructorDecl->init_begin(); it != ConstructorDecl->init
vmiklos added a comment.
In http://reviews.llvm.org/D22091#476756, @vmiklos wrote:
> Can you please postpone the cleanup till http://reviews.llvm.org/D21814 is
> reviewed? The two patches conflict with each other, I fear. Thanks. :-)
Ignore this, that one won't land as-is after all.
http://r
omtcyf0 added inline comments.
Comment at: clang-rename/USRLocFinder.h:38
@@ -37,2 +37,2 @@
-#endif // LLVM_CLANG_TOOLS_EXTRA_CLANG_RENAME_USR_LOC_FINDER_H
+#endif // LLVM_CLANG_TOOLS_EXTRA_CLANG_RENAME_USR_LOC_FINDER_H
bkramer wrote:
> In LLVM we usually have
omtcyf0 updated this revision to Diff 63093.
omtcyf0 marked an inline comment as done.
http://reviews.llvm.org/D22091
Files:
clang-rename/RenamingAction.cpp
clang-rename/USRLocFinder.cpp
clang-rename/USRLocFinder.h
clang-rename/tool/ClangRename.cpp
Index: clang-rename/tool/ClangRename.cp
bkramer added inline comments.
Comment at: clang-rename/USRLocFinder.h:38
@@ -37,2 +37,2 @@
-#endif // LLVM_CLANG_TOOLS_EXTRA_CLANG_RENAME_USR_LOC_FINDER_H
+#endif // LLVM_CLANG_TOOLS_EXTRA_CLANG_RENAME_USR_LOC_FINDER_H
In LLVM we usually have only one space be
vmiklos added a subscriber: vmiklos.
vmiklos added a comment.
Can you please postpone the cleanup till http://reviews.llvm.org/D21814 is
reviewed? The two patches conflict with each other, I fear. Thanks. :-)
http://reviews.llvm.org/D22091
___
cfe-
omtcyf0 created this revision.
omtcyf0 added reviewers: alexfh, klimek, bkramer, ioeric.
omtcyf0 added a subscriber: cfe-commits.
This patch does the following:
* enforces proper formatting for few files (i.e. deals with 80 linewidth
violations and few other things)
* ensures '\n' chars are pass
17 matches
Mail list logo
