This revision was automatically updated to reflect the committed changes.
Closed by commit rL275926: [OpenMP] Fix incorrect diagnostics in map clause
(authored by kli).
Changed prior to commit:
https://reviews.llvm.org/D22075?vs=64353&id=64410#toc
Repository:
rL LLVM
https://reviews.llvm.or
davidsh updated this revision to Diff 64353.
davidsh added a comment.
Fix a typo in code and address test case issues.
https://reviews.llvm.org/D22075
Files:
lib/Sema/SemaOpenMP.cpp
test/OpenMP/target_map_messages.cpp
test/OpenMP/target_parallel_for_map_messages.cpp
test/OpenMP/target_p
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D22075
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
davidsh updated this revision to Diff 63824.
davidsh added a comment.
Address formatting comment.
http://reviews.llvm.org/D22075
Files:
lib/Sema/SemaOpenMP.cpp
test/OpenMP/target_map_messages.cpp
Index: test/OpenMP/target_map_messages.cpp
===
ABataev added inline comments.
Comment at: lib/Sema/SemaOpenMP.cpp:10667-10668
@@ +10666,4 @@
+ if (Type.isNull() || Type->isAnyPointerType() ||
+ CheckArrayExpressionDoesNotReferToWholeSize(SemaRef,
+ SI->getAssociatedExpression(),Type))
+
davidsh updated this revision to Diff 63090.
davidsh added a comment.
Address comments
http://reviews.llvm.org/D22075
Files:
lib/Sema/SemaOpenMP.cpp
test/OpenMP/target_map_messages.cpp
Index: test/OpenMP/target_map_messages.cpp
==
sfantao added a comment.
Thanks. You have to wait for Alexey to take a look at the patch too.
Thanks again,
Samuel
http://reviews.llvm.org/D22075
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
sfantao added a comment.
Hi David,
Thanks for the fix!
Comment at: lib/Sema/SemaOpenMP.cpp:10639
@@ -10638,2 +10638,3 @@
break;
}
+while(SI != SE) {
You have to document what you are trying to accomplish here, something like
`"Che
davidsh created this revision.
davidsh added reviewers: carlo.bertolli, arpith-jacob, sfantao, ABataev, kkwli0.
davidsh added a subscriber: cfe-commits.
Having the following code pattern will result in incorrect diagnostic
int main() {
int arr[10];
#pragma omp target data map(arr[:])
#pragma omp t
