This revision was automatically updated to reflect the committed changes.
Closed by commit rL274201: [CodeView] Implement support for bitfields in Clang
(authored by majnemer).
Changed prior to commit:
http://reviews.llvm.org/D21783?vs=62095&id=62333#toc
Repository:
rL LLVM
http://reviews.l
rnk accepted this revision.
rnk added a comment.
lgtm
Cute, preserves debug info compatibility at the cost of some complexity.
http://reviews.llvm.org/D21783
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
aaboud accepted this revision.
aaboud added a comment.
This revision is now accepted and ready to land.
LGTM.
Please update PR28162.
http://reviews.llvm.org/D21783
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
majnemer updated this revision to Diff 62095.
majnemer added a comment.
- Address review comments
http://reviews.llvm.org/D21783
Files:
lib/CodeGen/CGDebugInfo.cpp
lib/CodeGen/CGDebugInfo.h
test/CodeGen/debug-info-packed-struct.c
test/CodeGenCXX/debug-info-ms-bitfields.cpp
Index: test/
aaboud added a comment.
Looks good, one minor comments below.
Comment at: lib/CodeGen/CGDebugInfo.h:243
@@ +242,3 @@
+ llvm::DIScope *RecordTy,
+ const RecordDecl *RD, SourceLocation Loc);
+
You
majnemer created this revision.
majnemer added reviewers: rnk, aaboud.
majnemer added a subscriber: cfe-commits.
Emit the underlying storage offset in addition to the starting bit
position of the field.
http://reviews.llvm.org/D21783
Files:
lib/CodeGen/CGDebugInfo.cpp
lib/CodeGen/CGDebugInfo
