Re: [PATCH] D21402: Add an Android version check for GNU strerror_r.

2016-06-15 Thread Dan Albert via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL272827: Add an Android version check for GNU strerror_r. (authored by danalbert). Changed prior to commit: http://reviews.llvm.org/D21402?vs=60887&id=60893#toc Repository: rL LLVM http://reviews.llv

Re: [PATCH] D21402: Add an Android version check for GNU strerror_r.

2016-06-15 Thread Eric Fiselier via cfe-commits
EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM. I would have preferred to always use the POSIX version, but it's impossible to turn of GNU extensions without breaking the linux build. http://reviews.llvm.org/D21402 __

[PATCH] D21402: Add an Android version check for GNU strerror_r.

2016-06-15 Thread Dan Albert via cfe-commits
danalbert created this revision. danalbert added reviewers: mclow.lists, EricWF. danalbert added a subscriber: cfe-commits. Herald added subscribers: srhines, danalbert, tberghammer. Android didn't gain GNU's strerror_r until Marshmallow. If we're building libc++ against something older (we build