Re: [PATCH] D20883: [cmake] Fix builds with LLVM_ENABLE_PIC=0

2016-06-02 Thread NAKAMURA Takumi via cfe-commits
chapuni added a subscriber: chapuni. chapuni added a comment. Have you tested if it might work? In fact, it didn't work. Comment at: cfe/trunk/test/CMakeLists.txt:78 @@ +77,3 @@ + + if(TARGET llvm-lto) +set(LLVM_TEST_DEPENDS ${LLVM_TEST_DEPENDS} llvm-lto) l

Re: [PATCH] D20883: [cmake] Fix builds with LLVM_ENABLE_PIC=0

2016-06-02 Thread Pavel Labath via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL271533: [cmake] Fix builds with LLVM_ENABLE_PIC=0 (authored by labath). Changed prior to commit: http://reviews.llvm.org/D20883?vs=59293&id=59405#toc Repository: rL LLVM http://reviews.llvm.org/D208

Re: [PATCH] D20883: [cmake] Fix builds with LLVM_ENABLE_PIC=0

2016-06-02 Thread Chris Bieneman via cfe-commits
beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. LGTM. http://reviews.llvm.org/D20883 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D20883: [cmake] Fix builds with LLVM_ENABLE_PIC=0

2016-06-01 Thread Pavel Labath via cfe-commits
labath created this revision. labath added a reviewer: beanz. labath added a subscriber: cfe-commits. When this flag is specified, the target llvm-lto is not built, but is still used as a dependency of the test targets. cmake 2.8 silently ignored this situation, but with cmake_minimum_required(3.4