rsmith added a subscriber: rsmith.
rsmith added a comment.
The summary and content of this patch are very different.
If you have an ABI variant that any language should be able to target, that
should be controlled by the triple and related flags, not by a RenderScript
language option.
If you w
pirama updated this revision to Diff 59294.
pirama removed a reviewer: rsmith.
pirama added a comment.
Herald added subscribers: danalbert, tberghammer.
Add a RenderScript langopt and updated to change long's size and alignment in
TargetInfo::adjust().
http://reviews.llvm.org/D20709
Files:
in
pirama added a reviewer: rsmith.
pirama added a comment.
Adding Richard to reviewers as the planned direction of this patch directly
relates to the Frontend.
http://reviews.llvm.org/D20709
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
pirama added a comment.
I looked at how LangOpts and TargetInfo are handled and found a way we can
achieve 64-bit longs without a Target feature (and restrict it just to
RenderScript!). This would be via TargetInfo::adjust(). I'll abandon the
sibling patch to LLVM as we should be able to do t
rengolin added a comment.
In http://reviews.llvm.org/D20709#443950, @srhines wrote:
> Correct. This is only used by RenderScript, and unfortunately can't be done
> any differently. We had hoped to just predicate this with our own LangOpt
> (the patch that adds the RenderScript LangOpt is coming
srhines added a comment.
In http://reviews.llvm.org/D20709#443536, @kristof.beyls wrote:
> Hi Pirama,
>
> My understanding is that this introduces (yet another) ARM 32 bit ABI variant
> - in this case with longs being 64 bit.
> My understanding is also that this is the ABI that is used in Rende
kristof.beyls added a comment.
Hi Pirama,
My understanding is that this introduces (yet another) ARM 32 bit ABI variant -
in this case with longs being 64 bit.
My understanding is also that this is the ABI that is used in Renderscript, and
this patch helps to remove local patches that currently
pirama created this revision.
pirama added a reviewer: kristof.beyls.
pirama added subscribers: srhines, cfe-commits.
Herald added subscribers: rengolin, aemerson.
Set alignment and width of long datatype to be 64-bits if the ARM
subtarget feature +long64 is set.
http://reviews.llvm.org/D20709
F
