Re: [PATCH] D20492: Clang support for __is_assignable intrinsic

2016-05-23 Thread David Majnemer via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL270458: Clang support for __is_assignable intrinsic (authored by majnemer). Changed prior to commit: http://reviews.llvm.org/D20492?vs=58014&id=58112#toc Repository: rL LLVM http://reviews.llvm.org/

Re: [PATCH] D20492: Clang support for __is_assignable intrinsic

2016-05-20 Thread Eric Fiselier via cfe-commits
EricWF added a subscriber: EricWF. EricWF added a comment. Should this have a test in `test/Lexer/has_feature_type_traits.cpp`? http://reviews.llvm.org/D20492 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

Re: [PATCH] D20492: Clang support for __is_assignable intrinsic

2016-05-20 Thread Dave Bartolomeo via cfe-commits
DaveBartolomeo updated this revision to Diff 58014. DaveBartolomeo added a comment. Removed unnecessary braces. Moved BTT_IsAssignable case to a more clear location. http://reviews.llvm.org/D20492 Files: docs/LanguageExtensions.rst include/clang/Basic/TokenKinds.def include/clang/Basic/Ty

Re: [PATCH] D20492: Clang support for __is_assignable intrinsic

2016-05-20 Thread David Majnemer via cfe-commits
majnemer added a subscriber: majnemer. Comment at: lib/Sema/SemaExprCXX.cpp:4523-4525 @@ -4521,1 +4522,5 @@ +if (BTT == BTT_IsAssignable) { + return true; +} + I'd remove the braces and sort it above the `BTT_IsNothrowAssignable` case. http://revi

[PATCH] D20492: Clang support for __is_assignable intrinsic

2016-05-20 Thread Dave Bartolomeo via cfe-commits
DaveBartolomeo created this revision. DaveBartolomeo added a reviewer: rnk. DaveBartolomeo added a subscriber: cfe-commits. MSVC now supports the __is_assignable type trait intrinsic, to enable easier and more efficient implementation of the Standard Library's is_assignable trait. As of Visual S