Re: [PATCH] D20420: [find-all-symbol] Add macro support.

2016-05-20 Thread Haojian Wu via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL270189: [find-all-symbol] Add macro support. (authored by hokein). Changed prior to commit: http://reviews.llvm.org/D20420?vs=57902&id=57903#toc Repository: rL LLVM http://reviews.llvm.org/D20420 F

Re: [PATCH] D20420: [find-all-symbol] Add macro support.

2016-05-20 Thread Haojian Wu via cfe-commits
hokein updated this revision to Diff 57902. hokein added a comment. Remove an unneeded file. http://reviews.llvm.org/D20420 Files: include-fixer/find-all-symbols/CMakeLists.txt include-fixer/find-all-symbols/FindAllMacros.cpp include-fixer/find-all-symbols/FindAllMacros.h include-fixer/

Re: [PATCH] D20420: [find-all-symbol] Add macro support.

2016-05-20 Thread Haojian Wu via cfe-commits
hokein updated this revision to Diff 57901. hokein added a comment. Correct the header comments. http://reviews.llvm.org/D20420 Files: include-fixer/find-all-symbols/CMakeLists.txt include-fixer/find-all-symbols/FindAllMacros.cpp include-fixer/find-all-symbols/FindAllMacros.h include-fi

Re: [PATCH] D20420: [find-all-symbol] Add macro support.

2016-05-19 Thread Benjamin Kramer via cfe-commits
bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. In the future I'd prefer to do renaming changes (ResultReporter->SymbolReporter) in a separate change, but this is fine now. Comment at: include-fixer/find-all-symbols/Symb

Re: [PATCH] D20420: [find-all-symbol] Add macro support.

2016-05-19 Thread Haojian Wu via cfe-commits
hokein updated this revision to Diff 57762. hokein marked 4 inline comments as done. hokein added a comment. Address comments. http://reviews.llvm.org/D20420 Files: include-fixer/find-all-symbols/CMakeLists.txt include-fixer/find-all-symbols/FindAllMacros.cpp include-fixer/find-all-symbol

Re: [PATCH] D20420: [find-all-symbol] Add macro support.

2016-05-19 Thread Eric Liu via cfe-commits
ioeric added inline comments. Comment at: include-fixer/find-all-symbols/FindAllMacros.h:22 @@ +21,3 @@ + +/// \brief A preprocessor collects macro symbols. The contexts of a macro will +/// be ignored since they are not available during preprocessing period. nit:

Re: [PATCH] D20420: [find-all-symbol] Add macro support.

2016-05-19 Thread Haojian Wu via cfe-commits
hokein updated this revision to Diff 57754. hokein added a comment. Fix code-style. http://reviews.llvm.org/D20420 Files: include-fixer/find-all-symbols/CMakeLists.txt include-fixer/find-all-symbols/FindAllMacros.cpp include-fixer/find-all-symbols/FindAllMacros.h include-fixer/find-all-

[PATCH] D20420: [find-all-symbol] Add macro support.

2016-05-19 Thread Haojian Wu via cfe-commits
hokein created this revision. hokein added a reviewer: bkramer. hokein added subscribers: ioeric, cfe-commits. http://reviews.llvm.org/D20420 Files: include-fixer/find-all-symbols/CMakeLists.txt include-fixer/find-all-symbols/FindAllMacros.cpp include-fixer/find-all-symbols/FindAllMacros.h