Re: [PATCH] D20404: [Driver] Fix driver support for color diagnostics

2016-05-31 Thread Bruno Cardoso Lopes via cfe-commits
bruno closed this revision. bruno added a comment. Committed in r271042 http://reviews.llvm.org/D20404 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20404: [Driver] Fix driver support for color diagnostics

2016-05-26 Thread Duncan P. N. Exon Smith via cfe-commits
LGTM. > On 2016-May-26, at 11:34, Bruno Cardoso Lopes wrote: > > bruno added a comment. > > Ping! > > > http://reviews.llvm.org/D20404 > > > ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

Re: [PATCH] D20404: [Driver] Fix driver support for color diagnostics

2016-05-26 Thread Duncan P. N. Exon Smith via cfe-commits
dexonsmith added a subscriber: dexonsmith. dexonsmith added a comment. LGTM. http://reviews.llvm.org/D20404 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20404: [Driver] Fix driver support for color diagnostics

2016-05-26 Thread Bruno Cardoso Lopes via cfe-commits
bruno added a comment. Ping! http://reviews.llvm.org/D20404 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20404: [Driver] Fix driver support for color diagnostics

2016-05-23 Thread Bruno Cardoso Lopes via cfe-commits
bruno added a comment. Ping! http://reviews.llvm.org/D20404 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20404: [Driver] Fix driver support for color diagnostics

2016-05-20 Thread Bruno Cardoso Lopes via cfe-commits
bruno added reviewers: dexonsmith, silvas. bruno removed subscribers: silvas, dexonsmith. bruno updated this revision to Diff 57993. bruno added a comment. Great idea Duncan, attached a new patch! http://reviews.llvm.org/D20404 Files: include/clang/Frontend/CompilerInvocation.h lib/Driver/T

Re: [PATCH] D20404: [Driver] Fix driver support for color diagnostics

2016-05-18 Thread Duncan P. N. Exon Smith via cfe-commits
dexonsmith added a comment. I don't think we even need a helper. Clang::ConstructJob takes a `Compilation`, which has a `Driver`, which has a `DiagnosticsEngine`, which has a `DiagnosticsOptions`. In other words, I think you can delete the code in Clang::ConstructJob (change it to a lookup) no

Re: [PATCH] D20404: [Driver] Fix driver support for color diagnostics

2016-05-18 Thread Duncan P. N. Exon Smith via cfe-commits
I don't think we even need a helper. Clang::ConstructJob takes a `Compilation`, which has a `Driver`, which has a `DiagnosticsEngine`, which has a `DiagnosticsOptions`. In other words, I think you can delete the code in Clang::ConstructJob (change it to a lookup) now that you've changed clang::

Re: [PATCH] D20404: [Driver] Fix driver support for color diagnostics

2016-05-18 Thread Sean Silva via cfe-commits
silvas added a subscriber: silvas. silvas added a comment. I don't see an issue with putthing this as a helper in libBasic. We may need to add a libOption dependency to it but that sounds fine. http://reviews.llvm.org/D20404 ___ cfe-commits mailing

[PATCH] D20404: [Driver] Fix driver support for color diagnostics

2016-05-18 Thread Bruno Cardoso Lopes via cfe-commits
bruno created this revision. bruno added a reviewer: rsmith. bruno added subscribers: cfe-commits, dexonsmith. Diagnostics that happen during driver time do not have color output support unless -fcolor-diagonostic is explicitly passed into the driver. OTOH, it works great for cc1 mode since dianos