Re: [PATCH] D20389: NVPTX: Add supported CL features

2016-06-17 Thread Jan Vesely via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL273031: NVPTX: Add supported CL features (authored by jvesely). Changed prior to commit: http://reviews.llvm.org/D20389?vs=60257&id=61119#toc Repository: rL LLVM http://reviews.llvm.org/D20389 File

Re: [PATCH] D20389: NVPTX: Add supported CL features

2016-06-17 Thread Justin Holewinski via cfe-commits
jholewinski accepted this revision. jholewinski added a comment. This revision is now accepted and ready to land. Looks good to me Repository: rL LLVM http://reviews.llvm.org/D20389 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://l

Re: [PATCH] D20389: NVPTX: Add supported CL features

2016-06-16 Thread Jan Vesely via cfe-commits
jvesely added a comment. ping @jholewinski, is the exported list of features OK with you? @Anastasia, are the tests OK now? Repository: rL LLVM http://reviews.llvm.org/D20389 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.

Re: [PATCH] D20389: NVPTX: Add supported CL features

2016-06-09 Thread Jan Vesely via cfe-commits
jvesely updated this revision to Diff 60257. jvesely added a comment. add back require registered target Repository: rL LLVM http://reviews.llvm.org/D20389 Files: lib/Basic/Targets.cpp test/Misc/nvptx.languageOptsOpenCL.cl Index: test/Misc/nvptx.languageOptsOpenCL.cl ===

Re: [PATCH] D20389: NVPTX: Add supported CL features

2016-06-09 Thread Jan Vesely via cfe-commits
jvesely marked 2 inline comments as done. jvesely added a comment. Repository: rL LLVM http://reviews.llvm.org/D20389 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20389: NVPTX: Add supported CL features

2016-06-09 Thread Jan Vesely via cfe-commits
jvesely updated this revision to Diff 60226. jvesely added a comment. Test all known extensions against expected nvptx outcome (add negative tests) Repository: rL LLVM http://reviews.llvm.org/D20389 Files: lib/Basic/Targets.cpp test/Misc/nvptx.languageOptsOpenCL.cl Index: test/Misc/nvpt

Re: [PATCH] D20389: NVPTX: Add supported CL features

2016-06-01 Thread Jan Vesely via cfe-commits
jvesely added inline comments. Comment at: test/Misc/nvptx.languageOptsOpenCL.cl:1 @@ +1,2 @@ +// REQUIRES: nvptx-registered-target +// RUN: %clang_cc1 -x cl -cl-std=CL %s -verify -triple nvptx-unknown-unknown Anastasia wrote: > Should we check for errors on unsup

Re: [PATCH] D20389: NVPTX: Add supported CL features

2016-06-01 Thread Anastasia Stulova via cfe-commits
Anastasia added inline comments. Comment at: test/Misc/nvptx.languageOptsOpenCL.cl:1 @@ +1,2 @@ +// REQUIRES: nvptx-registered-target +// RUN: %clang_cc1 -x cl -cl-std=CL %s -verify -triple nvptx-unknown-unknown Should we check for errors on unsupported extensions

Re: [PATCH] D20389: NVPTX: Add supported CL features

2016-05-27 Thread Jan Vesely via cfe-commits
jvesely updated the summary for this revision. jvesely added a subscriber: cfe-commits. jvesely updated this revision to Diff 58849. jvesely added a comment. Report only clinfo exported extensions. Repository: rL LLVM http://reviews.llvm.org/D20389 Files: lib/Basic/Targets.cpp test/Misc/