Re: [PATCH] D20240: [clang-rename] Fix broken dependency on shared build.

2016-05-13 Thread Etienne Bergeron via cfe-commits
etienneb added a comment. In http://reviews.llvm.org/D20240#429910, @vmiklos wrote: > Thanks for fixing the problem I introduced. :-) No worries, I did the same twice this week. http://reviews.llvm.org/D20240 ___ cfe-commits mailing list cfe-comm

Re: [PATCH] D20240: [clang-rename] Fix broken dependency on shared build.

2016-05-13 Thread Miklos Vajna via cfe-commits
vmiklos added a subscriber: vmiklos. vmiklos added a comment. Thanks for fixing the problem I introduced. :-) http://reviews.llvm.org/D20240 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

Re: [PATCH] D20240: [clang-rename] Fix broken dependency on shared build.

2016-05-13 Thread Etienne Bergeron via cfe-commits
etienneb added a comment. thanks, landing as soon as my other checkouts complete their tests (few minutes). http://reviews.llvm.org/D20240 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

Re: [PATCH] D20240: [clang-rename] Fix broken dependency on shared build.

2016-05-13 Thread Yaron Keren via cfe-commits
yaron.keren added a subscriber: yaron.keren. yaron.keren accepted this revision. yaron.keren added a reviewer: yaron.keren. yaron.keren added a comment. This revision is now accepted and ready to land. result of r269402, LGTM http://reviews.llvm.org/D20240 ___

[PATCH] D20240: [clang-rename] Fix broken dependency on shared build.

2016-05-13 Thread Etienne Bergeron via cfe-commits
etienneb created this revision. etienneb added a reviewer: alexfh. etienneb added a subscriber: cfe-commits. The build is broken due to a missing dependency. To repro: [Release + Shared] ``` -DCMAKE_BUILD_TYPE=Release -DBUILD_SHARED_LIBS=ON ``` Which produce this error: ``` tools/clang/tools/ext