Re: [PATCH] D20205: [include-fixer] Use scope contexts information to improve query.

2016-05-13 Thread Haojian Wu via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL269430: [include-fixer] Use scope contexts information to improve query. (authored by hokein). Changed prior to commit: http://reviews.llvm.org/D20205?vs=57197&id=57200#toc Repository: rL LLVM http:

Re: [PATCH] D20205: [include-fixer] Use scope contexts information to improve query.

2016-05-13 Thread Haojian Wu via cfe-commits
hokein updated this revision to Diff 57197. hokein added a comment. Rebase. http://reviews.llvm.org/D20205 Files: include-fixer/IncludeFixer.cpp include-fixer/SymbolIndexManager.cpp unittests/include-fixer/IncludeFixerTest.cpp Index: unittests/include-fixer/IncludeFixerTest.cpp =

Re: [PATCH] D20205: [include-fixer] Use scope contexts information to improve query.

2016-05-13 Thread Benjamin Kramer via cfe-commits
bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. Tests look much better now, thanks! http://reviews.llvm.org/D20205 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.or

Re: [PATCH] D20205: [include-fixer] Use scope contexts information to improve query.

2016-05-13 Thread Haojian Wu via cfe-commits
hokein updated this revision to Diff 57142. hokein added a comment. Improvement and use unittest. http://reviews.llvm.org/D20205 Files: include-fixer/IncludeFixer.cpp include-fixer/XrefsDBManager.cpp unittests/include-fixer/IncludeFixerTest.cpp Index: unittests/include-fixer/IncludeFixer

Re: [PATCH] D20205: [include-fixer] Use scope contexts information to improve query.

2016-05-12 Thread Benjamin Kramer via cfe-commits
bkramer requested changes to this revision. bkramer added a comment. This revision now requires changes to proceed. This needs more tests (check that using stuff from a different namespace in namespace scope still works). It's also better written as a unit test against the in-memory database, th