Re: [PATCH] D20132: [libclang] Add clang_getAllSkippedRanges function

2016-08-18 Thread Cameron via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL279076: [libclang] Add clang_getAllSkippedRanges function (authored by cameron314). Changed prior to commit: https://reviews.llvm.org/D20132?vs=56964&id=68548#toc Repository: rL LLVM https://reviews

Re: [PATCH] D20132: [libclang] Add clang_getAllSkippedRanges function

2016-08-18 Thread Cameron via cfe-commits
cameron314 added inline comments. Comment at: unittests/libclang/LibclangTest.cpp:16-20 @@ -15,4 +15,7 @@ #include "gtest/gtest.h" #include #include +#include +#include +#include #define DEBUG_TYPE "libclang-test" rsmith wrote: > Please put these in alpha

Re: [PATCH] D20132: [libclang] Add clang_getAllSkippedRanges function

2016-08-17 Thread Richard Smith via cfe-commits
rsmith accepted this revision. This revision is now accepted and ready to land. Comment at: unittests/libclang/LibclangTest.cpp:16-20 @@ -15,4 +15,7 @@ #include "gtest/gtest.h" #include #include +#include +#include +#include #define DEBUG_TYPE "libclang-test"

Re: [PATCH] D20132: [libclang] Add clang_getAllSkippedRanges function

2016-06-09 Thread Cameron via cfe-commits
cameron314 added a comment. Can someone have a look at this now that there's a test? http://reviews.llvm.org/D20132 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20132: [libclang] Add clang_getAllSkippedRanges function

2016-05-11 Thread Cameron via cfe-commits
cameron314 updated this revision to Diff 56964. cameron314 added a comment. Here's a test! http://reviews.llvm.org/D20132 Files: include/clang-c/Index.h tools/libclang/CIndex.cpp unittests/libclang/LibclangTest.cpp Index: unittests/libclang/LibclangTest.cpp ==

Re: [PATCH] D20132: [libclang] Add clang_getAllSkippedRanges function

2016-05-10 Thread Richard Smith via cfe-commits
rsmith added a comment. This looks reasonable, but please add a test. http://reviews.llvm.org/D20132 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D20132: [libclang] Add clang_getAllSkippedRanges function

2016-05-10 Thread Cameron via cfe-commits
cameron314 created this revision. cameron314 added a reviewer: rsmith. cameron314 added a subscriber: cfe-commits. This complements the `clang_getSkippedRanges` function which returns skipped ranges filtered by a specific file. This function is useful when all the ranges are desired (and a lot m