Re: [PATCH] D20045: [ObjC][CodeGen] Remove an assert that is no longer correct.

This revision was automatically updated to reflect the committed changes. Closed by commit rL269385: [ObjC][CodeGen] Remove an assert that is no longer correct. (authored by ahatanak). Changed prior to commit: http://reviews.llvm.org/D20045?vs=57111&id=57125#toc Repository: rL LLVM http://r

Re: [PATCH] D20045: [ObjC][CodeGen] Remove an assert that is no longer correct.

rjmccall added a comment. LGTM, thanks. http://reviews.llvm.org/D20045 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20045: [ObjC][CodeGen] Remove an assert that is no longer correct.

ahatanak updated this revision to Diff 57111. ahatanak added a comment. Thanks, I updated the comment in the new patch. http://reviews.llvm.org/D20045 Files: lib/CodeGen/CGExpr.cpp test/CodeGenObjCXX/arc-cxx11-init-list.mm Index: test/CodeGenObjCXX/arc-cxx11-init-list.mm ==

Re: [PATCH] D20045: [ObjC][CodeGen] Remove an assert that is no longer correct.

rjmccall added inline comments. Comment at: lib/CodeGen/CGExpr.cpp:365 @@ +364,3 @@ + // If the global variable already has an initializer, there is no need to + // emit code for initialization or push a cleanup. + if (Var->hasInitializer()) As we d

Re: [PATCH] D20045: [ObjC][CodeGen] Remove an assert that is no longer correct.

ahatanak added a comment. In http://reviews.llvm.org/D20045#425903, @manmanren wrote: > After r231508 made changes to promote constant temporaries to globals, the > assert fires when a std::initializer_list is constructed using Objective-C > string literals. > > --> Can you explain the code pat

Re: [PATCH] D20045: [ObjC][CodeGen] Remove an assert that is no longer correct.

ahatanak updated this revision to Diff 57088. ahatanak added a comment. Add a comment explaining why it is OK to return early if the global variable has an initializer. http://reviews.llvm.org/D20045 Files: lib/CodeGen/CGExpr.cpp test/CodeGenObjCXX/arc-cxx11-init-list.mm Index: test/CodeG

Re: [PATCH] D20045: [ObjC][CodeGen] Remove an assert that is no longer correct.

manmanren added a comment. After r231508 made changes to promote constant temporaries to globals, the assert fires when a std::initializer_list is constructed using Objective-C string literals. --> Can you explain the code path after r231508 for your example? Will r231508 change the code path

[PATCH] D20045: [ObjC][CodeGen] Remove an assert that is no longer correct.

ahatanak created this revision. ahatanak added reviewers: rjmccall, rsmith, manmanren. ahatanak added a subscriber: cfe-commits. The assert was committed in r183967. After r231508 made changes to promote constant temporaries to globals, the assert fires when a std::initializer_list is constructe