Re: [PATCH] D19913: Added static creators that create complete instances of SymbolInfo.

2016-05-09 Thread Eric Liu via cfe-commits
ioeric added inline comments. Comment at: include-fixer/find-all-symbols/SymbolInfo.h:98-101 @@ +97,6 @@ + + static SymbolInfo + CreateFunctionSymbolInfo(const std::string &Name, const std::string &FilePath, + const std::vector &Contexts, int LineNumb

Re: [PATCH] D19913: Added static creators that create complete instances of SymbolInfo.

2016-05-04 Thread Manuel Klimek via cfe-commits
klimek added inline comments. Comment at: include-fixer/find-all-symbols/SymbolInfo.h:98-101 @@ +97,6 @@ + + static SymbolInfo + CreateFunctionSymbolInfo(const std::string &Name, const std::string &FilePath, + const std::vector &Contexts, int LineNumb

Re: [PATCH] D19913: Added static creators that create complete instances of SymbolInfo.

2016-05-04 Thread Haojian Wu via cfe-commits
hokein added a comment. It looks good to me now, but need to wait @klimek acceptance. Comment at: include-fixer/find-all-symbols/SymbolInfo.h:98-101 @@ +97,6 @@ + + static SymbolInfo + CreateFunctionSymbolInfo(const std::string &Name, const std::string &FilePath, +

Re: [PATCH] D19913: Added static creators that create complete instances of SymbolInfo.

2016-05-04 Thread Eric Liu via cfe-commits
ioeric updated this revision to Diff 56148. ioeric added a comment. - Removed SetCommonInfo declaration from header. http://reviews.llvm.org/D19913 Files: include-fixer/InMemoryXrefsDB.cpp include-fixer/find-all-symbols/SymbolInfo.cpp include-fixer/find-all-symbols/SymbolInfo.h unittest

Re: [PATCH] D19913: Added static creators that create complete instances of SymbolInfo.

2016-05-04 Thread Eric Liu via cfe-commits
ioeric updated this revision to Diff 56147. ioeric added a comment. - Removed unused function in unit test. http://reviews.llvm.org/D19913 Files: include-fixer/InMemoryXrefsDB.cpp include-fixer/find-all-symbols/SymbolInfo.cpp include-fixer/find-all-symbols/SymbolInfo.h unittests/include

Re: [PATCH] D19913: Added static creators that create complete instances of SymbolInfo.

2016-05-04 Thread Haojian Wu via cfe-commits
hokein added inline comments. Comment at: unittests/include-fixer/find-all-symbols/FindAllSymbolsTests.cpp:92 @@ -107,5 +91,3 @@ -SymbolInfo -CreateSymbolInfo(StringRef Name, SymbolInfo::SymbolKind Type, - const std::string FilePath, int LineNumber, -

Re: [PATCH] D19913: Added static creators that create complete instances of SymbolInfo.

2016-05-04 Thread Eric Liu via cfe-commits
ioeric updated this revision to Diff 56145. ioeric added a comment. - Use template to compare llvm::Optional types. http://reviews.llvm.org/D19913 Files: include-fixer/InMemoryXrefsDB.cpp include-fixer/find-all-symbols/SymbolInfo.cpp include-fixer/find-all-symbols/SymbolInfo.h unittests

Re: [PATCH] D19913: Added static creators that create complete instances of SymbolInfo.

2016-05-04 Thread Eric Liu via cfe-commits
ioeric updated this revision to Diff 56143. ioeric added a comment. - Use static creator functions in SymbolInfo in FindAllSymbolTests, and make SymbolInfo::operator== compare all fields. http://reviews.llvm.org/D19913 Files: include-fixer/InMemoryXrefsDB.cpp include-fixer/find-all-symbols

Re: [PATCH] D19913: Added static creators that create complete instances of SymbolInfo.

2016-05-04 Thread Eric Liu via cfe-commits
ioeric updated this revision to Diff 56139. ioeric marked 7 inline comments as done. ioeric added a comment. Use static creator functions in SymbolInfo in FindAllSymbolTests, and make SymbolInfo::operator== compare all fields. http://reviews.llvm.org/D19913 Files: include-fixer/find-all-symb

Re: [PATCH] D19913: Added static creators that create complete instances of SymbolInfo.

2016-05-04 Thread Manuel Klimek via cfe-commits
klimek added inline comments. Comment at: include-fixer/find-all-symbols/SymbolInfo.h:90-93 @@ +89,6 @@ + + static SymbolInfo + CreateFunctionSymbolInfo(const std::string &Name, const std::string &FilePath, + const std::vector &Contexts, int LineNumbe

Re: [PATCH] D19913: Added static creators that create complete instances of SymbolInfo.

2016-05-04 Thread Eric Liu via cfe-commits
ioeric added inline comments. Comment at: include-fixer/find-all-symbols/SymbolInfo.h:90-93 @@ +89,6 @@ + + static SymbolInfo + CreateFunctionSymbolInfo(const std::string &Name, const std::string &FilePath, + const std::vector &Contexts, int LineNumbe

Re: [PATCH] D19913: Added static creators that create complete instances of SymbolInfo.

2016-05-04 Thread Haojian Wu via cfe-commits
hokein added a comment. Not sure whether this is what @klimek expected.. You also need to update the FindAllSymbolsTests code (there is a CreateSymbolInfo function there). Comment at: include-fixer/find-all-symbols/SymbolInfo.cpp:91 @@ +90,3 @@ +void SymbolInfo::SetCommonInfo(

Re: [PATCH] D19913: Added static creators that create complete instances of SymbolInfo.

2016-05-04 Thread Manuel Klimek via cfe-commits
klimek added inline comments. Comment at: include-fixer/find-all-symbols/SymbolInfo.h:90-93 @@ +89,6 @@ + + static SymbolInfo + CreateFunctionSymbolInfo(const std::string &Name, const std::string &FilePath, + const std::vector &Contexts, int LineNumbe

[PATCH] D19913: Added static creators that create complete instances of SymbolInfo.

2016-05-04 Thread Eric Liu via cfe-commits
ioeric created this revision. ioeric added reviewers: klimek, hokein. ioeric added a subscriber: cfe-commits. Added static creators that create complete instances of SymbolInfo. http://reviews.llvm.org/D19913 Files: include-fixer/InMemoryXrefsDB.cpp include-fixer/find-all-symbols/SymbolInfo.