Re: [PATCH] D19856: Create new library 'libc++experimental.a' for packaging TS symbols.

2016-05-03 Thread Eric Fiselier via cfe-commits
EricWF added a comment. In http://reviews.llvm.org/D19856#420366, @mclow.lists wrote: > Q: Should the .a file get installed into /lib when you do a make install? > > That will make it easier to link against. For now the install rule is off by default. `-DLIBCXX_INSTALL_EXPERIMENTAL_LIBRARY=ON

Re: [PATCH] D19856: Create new library 'libc++experimental.a' for packaging TS symbols.

2016-05-03 Thread Marshall Clow via cfe-commits
mclow.lists added a comment. Q: Should the .a file get installed into /lib when you do a make install? That will make it easier to link against. http://reviews.llvm.org/D19856 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.ll

Re: [PATCH] D19856: Create new library 'libc++experimental.a' for packaging TS symbols.

2016-05-03 Thread Marshall Clow via cfe-commits
mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. I like this approach. LGTM. http://reviews.llvm.org/D19856 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.or

Re: [PATCH] D19856: Create new library 'libc++experimental.a' for packaging TS symbols.

2016-05-03 Thread Ben Craig via cfe-commits
bcraig added a comment. LGTM http://reviews.llvm.org/D19856 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19856: Create new library 'libc++experimental.a' for packaging TS symbols.

2016-05-02 Thread Eric Fiselier via cfe-commits
EricWF added a subscriber: cfe-commits. EricWF added a comment. Adding cfe-commits to the subscribers. http://reviews.llvm.org/D19856 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits