This revision was automatically updated to reflect the committed changes.
Closed by commit rL268078: [Clang][Darwin] Define __ARM_DWARF_EH__ for WatchABI
(authored by cbieneman).
Changed prior to commit:
http://reviews.llvm.org/D19693?vs=55626&id=55627#toc
Repository:
rL LLVM
http://reviews
t.p.northover accepted this revision.
t.p.northover added a comment.
This revision is now accepted and ready to land.
Looks good. Thanks Chris!
http://reviews.llvm.org/D19693
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.
beanz updated this revision to Diff 55626.
beanz added a comment.
Adding a test case, and properly rebasing on trunk.
http://reviews.llvm.org/D19693
Files:
lib/Basic/Targets.cpp
test/Preprocessor/arm-target-features.c
Index: test/Preprocessor/arm-target-features.c
=
Yea… Arc seems to have done something odd with my out-of-date checkout.
I’ll make sure that gets cleaned up, and I’ll add a test.
Thanks,
-Chris
> On Apr 28, 2016, at 3:23 PM, Tim Northover wrote:
>
> t.p.northover added a comment.
>
> The __ARM_DWARF_EH__ change looks reasonable, but it's pr
beanz added a subscriber: beanz.
beanz added a comment.
Yea… Arc seems to have done something odd with my out-of-date checkout.
I’ll make sure that gets cleaned up, and I’ll add a test.
Thanks,
-Chris
http://reviews.llvm.org/D19693
___
cfe-commits
t.p.northover added a comment.
The __ARM_DWARF_EH__ change looks reasonable, but it's probably an idea to put
a check into tools/clang/tests/Preprocessor/arm-target-features.c (watch is
checked with "ARMV7K").
The rest of the changes look like they're from an unsynchronized branch?
http://rev
beanz created this revision.
beanz added a reviewer: t.p.northover.
beanz added a subscriber: cfe-commits.
Herald added subscribers: rengolin, aemerson.
The Darwin armv7k ABI uses Dwarf EH, so we need to set the OS define correctly.
Without this the gcc_personality fails to build.
http://reviews
