tmsriram closed this revision.
tmsriram added a comment.
267948
http://reviews.llvm.org/D19687
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tmsriram updated this revision to Diff 55493.
tmsriram added a comment.
Simplify code setting PICLevel and PIELevel module flags.
http://reviews.llvm.org/D19687
Files:
lib/CodeGen/CodeGenModule.cpp
Index: lib/CodeGen/CodeGenModule.cpp
=
tmsriram created this revision.
tmsriram added reviewers: rnk, davidxl.
tmsriram added a subscriber: cfe-commits.
In patch http://reviews.llvm.org/D19671, I added a patch to create PIELevel
module flag. This patch sets the flag.
http://reviews.llvm.org/D19687
Files:
lib/CodeGen/CodeGenModule
rnk added a comment.
still lgtm
Comment at: lib/CodeGen/CodeGenModule.cpp:480
@@ -479,8 +479,3 @@
if (uint32_t PLevel = Context.getLangOpts().PICLevel) {
-llvm::PICLevel::Level PL = llvm::PICLevel::Default;
-switch (PLevel) {
-case 0: break;
-case 1: PL = llvm
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Comment at: lib/CodeGen/CodeGenModule.cpp:492-498
@@ +491,9 @@
+ if (uint32_t PLevel = Context.getLangOpts().PIELevel) {
+llvm::PIELevel::Level PL = llvm::PIELevel::Defaul
