This revision was automatically updated to reflect the committed changes.
Closed by commit rL268532: [CodeGenObjCXX] Fix handling of blocks in lambda.
(authored by ahatanak).
Changed prior to commit:
http://reviews.llvm.org/D19536?vs=56090&id=56183#toc
Repository:
rL LLVM
http://reviews.llv
rjmccall added a comment.
Yes, that looks good, thanks.
http://reviews.llvm.org/D19536
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ahatanak updated this revision to Diff 56090.
ahatanak added a comment.
Apply John's patch with a few modifications.
I had to special case __block variables and remove the line creating a load
from a reference to fix the failing regression tests.
http://reviews.llvm.org/D19536
Files:
lib/Co
ahatanak added inline comments.
Comment at: lib/CodeGen/CGBlocks.cpp:806
@@ -792,1 +805,3 @@
+ }
+ src = Builder.CreateStructGEP(Addr, Idx, Offset, FD->getName());
} else {
rjmccall wrote:
> Hmm. It's become increasingly clear that my original deci
rjmccall added inline comments.
Comment at: lib/CodeGen/CGBlocks.cpp:806
@@ -792,1 +805,3 @@
+ }
+ src = Builder.CreateStructGEP(Addr, Idx, Offset, FD->getName());
} else {
Hmm. It's become increasingly clear that my original decision to expand the
ahatanak created this revision.
ahatanak added a reviewer: rjmccall.
ahatanak added a subscriber: cfe-commits.
This fixes a crash that occurs when a block nested in a c++ lambda captures a
reference that is captured by the enclosing lambda.
rdar://problem/18586651
http://reviews.llvm.org/D19536
