Re: [PATCH] D19415: [libcxx][rfc] Externalized threading support

2016-05-17 Thread Asiri Rathnayake via cfe-commits
rmaprath abandoned this revision. rmaprath added a comment. Superseded by http://reviews.llvm.org/D20328. http://reviews.llvm.org/D19415 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

Re: [PATCH] D19415: [libcxx][rfc] Externalized threading support

2016-05-03 Thread Asiri Rathnayake via cfe-commits
rmaprath updated this revision to Diff 55967. rmaprath added a comment. Re-spun on top of http://reviews.llvm.org/D19412. http://reviews.llvm.org/D19415 Files: include/__threading_support src/algorithm.cpp src/memory.cpp src/mutex.cpp Index: src/mutex.cpp ==

Re: [PATCH] D19415: [libcxx][rfc] Externalized threading support

2016-04-29 Thread Asiri Rathnayake via cfe-commits
rmaprath updated this revision to Diff 55573. rmaprath added a comment. Minor re-spin on http://reviews.llvm.org/D19412. http://reviews.llvm.org/D19415 Files: include/__threading_support Index: include/__threading_support === --

Re: [PATCH] D19415: [libcxx][rfc] Externalized threading support

2016-04-29 Thread Asiri Rathnayake via cfe-commits
rmaprath updated this revision to Diff 55570. rmaprath added a comment. Re-sync with http://reviews.llvm.org/D19412. http://reviews.llvm.org/D19415 Files: include/__threading_support Index: include/__threading_support === --- in

Re: [PATCH] D19415: [libcxx][rfc] Externalized threading support

2016-04-28 Thread Asiri Rathnayake via cfe-commits
rmaprath updated this revision to Diff 55503. rmaprath added a comment. Updating to syc-up with http://reviews.llvm.org/D19412. Obviously, this patch needs more work in terms of setting up the testing story (using a pthreads based implementation of the threading API). http://reviews.llvm.org/D

Re: [PATCH] D19415: [libcxx][rfc] Externalized threading support

2016-04-27 Thread Ben Craig via cfe-commits
bcraig added a comment. LGTM. You will still need to get approval from one of your original reviewers though. http://reviews.llvm.org/D19415 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

Re: [PATCH] D19415: [libcxx][rfc] Externalized threading support

2016-04-26 Thread Asiri Rathnayake via cfe-commits
rmaprath updated this revision to Diff 55127. rmaprath added a comment. Addressing review comments from @bcraig: Adjusted according to the changes of http://reviews.llvm.org/D19412. This patch is now mostly trivial. There is a small catch in that, this version of the API takes pointer-to-point

Re: [PATCH] D19415: [libcxx][rfc] Externalized threading support

2016-04-26 Thread Ben Craig via cfe-commits
bcraig added a subscriber: bcraig. bcraig added a comment. Note: My opinion doesn't count for much as far as community acceptance goes. I'm fine with the idea. I think there is at least one significant conformance hurdle that you will need to address though. I also have some commentary on th

Re: [PATCH] D19415: [libcxx][rfc] Externalized threading support

2016-04-26 Thread Asiri Rathnayake via cfe-commits
rmaprath added a comment. I forgot to mention that we will need a similar (although much smaller) porting layer for `libcxxabi` and `libunwind`, as those too currently have a pthread dependency. http://reviews.llvm.org/D19415 ___ cfe-commits maili

[PATCH] D19415: [libcxx][rfc] Externalized threading support

2016-04-22 Thread Asiri Rathnayake via cfe-commits
rmaprath created this revision. rmaprath added reviewers: EricWF, mclow.lists, theraven, jroelofs. rmaprath added a subscriber: cfe-commits. Herald added a subscriber: aemerson. This patch builds on D19412. The motivation here is to allow toolchain vendors to build a version of `libcxx` with all