apelete updated this revision to Diff 56259.
apelete added a comment.
[scan-build] fix warnings emitted on Clang Format code base
Changes since last revision:
- split patch into Format unit to ease review process.
http://reviews.llvm.org/D19385
Files:
lib/Format/AffectedRangeManager.cpp
l
apelete updated this revision to Diff 55757.
apelete added a comment.
[scan-build] fix logic error warnings emitted on clang code base
Changes since last revision:
- lib/Format/AffectedRangeManager.cpp: fix typo in class name.
http://reviews.llvm.org/D19385
Files:
lib/AST/DeclObjC.cpp
lib
apelete added a comment.
Waiting for review, could someone please have a look at this one ?
http://reviews.llvm.org/D19385
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
apelete updated this revision to Diff 55748.
apelete added a comment.
[scan-build] fix logic error warnings emitted on clang code base
Changes since last revision:
- fast forward rebase on git master branch.
http://reviews.llvm.org/D19385
Files:
lib/AST/DeclObjC.cpp
lib/Format/AffectedRan
apelete added a comment.
Thanks for your reviews.
http://reviews.llvm.org/D19385
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
apelete updated this revision to Diff 55487.
apelete marked 3 inline comments as done.
apelete added a comment.
[scan-build] fix logic error warnings emitted on clang code base
Changes since last revision:
- lib/Format/AffectedRangeManager.cpp: fix the call to
AffectedRangeManager::nonPPLineAff
apelete updated this revision to Diff 55483.
apelete added a comment.
[scan-build] fix logic error warnings emitted on clang code base
Changes since last revison:
- lib/Format/AffectedRangeManager.h: fix declaration of nonPPLineAffected() to
pass a reference to AnnotatedLine as first parameter.
djasper added inline comments.
Comment at: lib/Format/AffectedRangeManager.cpp:103
@@ -102,1 +102,3 @@
AnnotatedLine *Line, const AnnotatedLine *PreviousLine) {
+ assert(Line && "does not contain any line");
+
klimek wrote:
> Perhaps we should change this to
klimek added a reviewer: djasper.
Comment at: lib/Format/AffectedRangeManager.cpp:103
@@ -102,1 +102,3 @@
AnnotatedLine *Line, const AnnotatedLine *PreviousLine) {
+ assert(Line && "does not contain any line");
+
Perhaps we should change this to take a Line&
zaks.anna added inline comments.
Comment at: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:300-301
@@ -299,3 +299,4 @@
+ assert(SM && "SourceManager is NULL, cannot iterate through the
diagnostics");
for (std::vector::iterator DI = Diags.begin(),
LGTM
ht
apelete updated this revision to Diff 55327.
apelete added a comment.
[scan-build] fix logic error warnings emitted on clang code base
Changes since last revision:
- lib/Format/AffectedRangeManager.cpp: moved the fixes from
lib/Format/Format.cpp:AffectedRangeManager::nonPPLineAffected() here si
apelete updated this revision to Diff 55103.
apelete added a comment.
[scan-build] fix logic error warnings emitted on clang code base
Chnages since last revision:
- lib/Format/Format.cpp: removed all changes, redenderd obsolete by upstream.
http://reviews.llvm.org/D19385
Files:
lib/AST/Dec
rjmccall added inline comments.
Comment at: lib/Frontend/CompilerInstance.cpp:763
@@ -762,8 +762,3 @@
Includers.push_back(std::make_pair(FindFile, FindFile->getDir()));
- File = HS->LookupFile(InputFile, SourceLocation(), /*isAngled=*/false,
-
apelete added inline comments.
Comment at: lib/Frontend/CompilerInstance.cpp:763
@@ -762,8 +762,3 @@
Includers.push_back(std::make_pair(FindFile, FindFile->getDir()));
- File = HS->LookupFile(InputFile, SourceLocation(), /*isAngled=*/false,
-
rjmccall added inline comments.
Comment at: lib/Frontend/CompilerInstance.cpp:763
@@ -762,8 +762,3 @@
Includers.push_back(std::make_pair(FindFile, FindFile->getDir()));
- File = HS->LookupFile(InputFile, SourceLocation(), /*isAngled=*/false,
-
apelete created this revision.
apelete added reviewers: rjmccall, zaks.anna, rsmith.
apelete added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
Fixing another set of "Logic error" warnings of the type "Called c++
object pointer is null" reported by Clang Static Analyzer on the
fol
16 matches
Mail list logo
