Re: [PATCH] D19344: [libc++] fix macro redef warning when exception is disabled

2016-04-20 Thread Weiming Zhao via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL266956: [libc++] fix macro redef warning when exception is disabled (authored by weimingz). Changed prior to commit: http://reviews.llvm.org/D19344?vs=54457&id=54459#toc Repository: rL LLVM http://r

Re: [PATCH] D19344: [libc++] fix macro redef warning when exception is disabled

2016-04-20 Thread Eric Fiselier via cfe-commits
EricWF added a comment. s/than you/thank you http://reviews.llvm.org/D19344 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19344: [libc++] fix macro redef warning when exception is disabled

2016-04-20 Thread Eric Fiselier via cfe-commits
EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM. Normally system header would simply ignore this problem. However it's valuable to compile libc++ as a non-system header for both users and developers. Than you for the patch. http://r

Re: [PATCH] D19344: [libc++] fix macro redef warning when exception is disabled

2016-04-20 Thread Weiming Zhao via cfe-commits
weimingz retitled this revision from "[libc++] fix constexpr error when build with MUSL and macro redef warning when no exception" to "[libc++] fix macro redef warning when exception is disabled". weimingz updated the summary for this revision. weimingz updated this revision to Diff 54457. http: