Re: [PATCH] D19242: clang-format: [JS] simplify import/export.

2016-04-19 Thread Martin Probst via cfe-commits
mprobst marked an inline comment as done. mprobst added a comment. Repository: rL LLVM http://reviews.llvm.org/D19242 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19242: clang-format: [JS] simplify import/export.

2016-04-19 Thread Martin Probst via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL266743: clang-format: [JS] simplify import/export. (authored by mprobst). Changed prior to commit: http://reviews.llvm.org/D19242?vs=54124&id=54190#toc Repository: rL LLVM http://reviews.llvm.org/D1

Re: [PATCH] D19242: clang-format: [JS] simplify import/export.

2016-04-19 Thread Daniel Jasper via cfe-commits
djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Looks good. Comment at: lib/Format/UnwrappedLineParser.cpp:1900 @@ +1899,3 @@ + // to the terminating `;`. For everything else, just return and continue + // parsing the s

[PATCH] D19242: clang-format: [JS] simplify import/export.

2016-04-18 Thread Martin Probst via cfe-commits
mprobst created this revision. mprobst added a reviewer: djasper. mprobst added a subscriber: cfe-commits. Herald added a subscriber: klimek. Change `import` and `export` parsing to special case the renaming syntax (`import x, {y as bar} ...`, `export {x}`) and otherwise just parse a regular struc