Re: [PATCH] D19084: [scan-build] fix warnings emitted on Clang AST code base

2016-05-18 Thread Apelete Seketeli via cfe-commits
apelete updated this revision to Diff 57571. apelete retitled this revision from "[scan-build] fix warnings emitted on Clang AST code base " to "[scan-build] fix warnings emitted on Clang AST code base". apelete added a comment. [scan-build] fix warnings emitted on Clang AST code base Changes si

Re: [PATCH] D19084: [scan-build] fix warnings emitted on Clang AST code base

2016-05-12 Thread Richard Trieu via cfe-commits
rtrieu added inline comments. Comment at: lib/AST/ASTDiagnostic.cpp:1686 @@ -1685,3 +1685,3 @@ -if (Same) { +if (Same && FromTD) { OS << "template " << FromTD->getNameAsString(); apelete wrote: > rtrieu wrote: > > dblaikie wrote: > > > Should this

Re: [PATCH] D19084: [scan-build] fix warnings emitted on Clang AST code base

2016-05-12 Thread Apelete Seketeli via cfe-commits
apelete added inline comments. Comment at: lib/AST/ASTDiagnostic.cpp:1686 @@ -1685,3 +1685,3 @@ -if (Same) { +if (Same && FromTD) { OS << "template " << FromTD->getNameAsString(); rtrieu wrote: > dblaikie wrote: > > Should this be a condition, or

Re: [PATCH] D19084: [scan-build] fix warnings emitted on Clang AST code base

2016-05-05 Thread Richard Trieu via cfe-commits
rtrieu added inline comments. Comment at: lib/AST/ASTDiagnostic.cpp:1686 @@ -1685,3 +1685,3 @@ -if (Same) { +if (Same && FromTD) { OS << "template " << FromTD->getNameAsString(); dblaikie wrote: > Should this be a condition, or just an assertion?

Re: [PATCH] D19084: [scan-build] fix warnings emitted on Clang AST code base

2016-05-05 Thread David Blaikie via cfe-commits
dblaikie added a subscriber: dblaikie. Comment at: lib/AST/ASTDiagnostic.cpp:1686 @@ -1685,3 +1685,3 @@ -if (Same) { +if (Same && FromTD) { OS << "template " << FromTD->getNameAsString(); Should this be a condition, or just an assertion?