This appears to be a different direction from what we'd agreed upon. Please
update the original thread with discussion and your intentions and a
breakdown of costs, long-term maintainability, and your plans here.
Thanks.
On Mon, Apr 18, 2016 at 2:07 PM Eric Christopher via cfe-commits <
cfe-commi
echristo requested changes to this revision.
echristo added a comment.
This revision now requires changes to proceed.
As a note I'm going to want to review this before it goes in.
http://reviews.llvm.org/D19072
___
cfe-commits mailing list
cfe-commi
rnk marked an inline comment as done.
Comment at: lib/CodeGen/CGDebugInfo.h:97
@@ -273,3 +96,3 @@
/// Set the main CU's DwoId field to \p Signature.
- void setDwoId(uint64_t Signature);
+ virtual void setDwoId(uint64_t Signature) = 0;
aprantl wrote:
> Why d
aprantl added inline comments.
Comment at: lib/CodeGen/CGDebugInfo.h:97
@@ -273,3 +96,3 @@
/// Set the main CU's DwoId field to \p Signature.
- void setDwoId(uint64_t Signature);
+ virtual void setDwoId(uint64_t Signature) = 0;
Why does this need to be virt
rnk added a comment.
ping
http://reviews.llvm.org/D19072
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk marked 2 inline comments as done.
Comment at: lib/CodeGen/CodeGenModule.h:292
@@ -291,3 +291,3 @@
CGCUDARuntime* CUDARuntime;
- CGDebugInfo* DebugInfo;
+ std::unique_ptr DebugInfo;
ObjCEntrypoints *ObjCData;
echristo wrote:
> aprantl wrote:
> > This co
echristo added inline comments.
Comment at: lib/CodeGen/CodeGenModule.h:292
@@ -291,3 +291,3 @@
CGCUDARuntime* CUDARuntime;
- CGDebugInfo* DebugInfo;
+ std::unique_ptr DebugInfo;
ObjCEntrypoints *ObjCData;
aprantl wrote:
> This could be a separate useful N
aprantl added inline comments.
Comment at: lib/CodeGen/CodeGenModule.h:292
@@ -291,3 +291,3 @@
CGCUDARuntime* CUDARuntime;
- CGDebugInfo* DebugInfo;
+ std::unique_ptr DebugInfo;
ObjCEntrypoints *ObjCData;
This could be a separate useful NFC commit.
http:
