Re: [PATCH] D18919: Add check "modernize use using"

2016-04-09 Thread Jakub StaroĊ„ via cfe-commits
staronj added inline comments. Comment at: clang-tidy/modernize/UseUsingCheck.h:19 @@ +18,3 @@ + +/// FIXME: Write a short description. +/// Fix the FIXME. Comment at: test/clang-tidy/modernize-use-using.cpp:76 @@ +75,1 @@ +// CHECK-FIXES: using

[PATCH] D18919: Add check "modernize use using"

2016-04-09 Thread Krystyna via cfe-commits
krystyna created this revision. krystyna added reviewers: Prazek, mnbvmar, staronj, alexfh. krystyna added a subscriber: cfe-commits. http://reviews.llvm.org/D18919 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/UseUsingCheck.cpp

Re: [PATCH] D18919: Add check "modernize use using"

2016-04-09 Thread Piotr Padlewski via cfe-commits
Prazek added inline comments. Comment at: docs/clang-tidy/checks/modernize-use-using.rst:13 @@ +12,3 @@ + typedef int variable; + +After: add cases with pointers to function / members http://reviews.llvm.org/D18919 ___