aaron.ballman abandoned this revision.
aaron.ballman added a comment.
Closing this via "abandon" so that Richard doesn't have to accept it in order
for me to close it. It's already been committed.
https://reviews.llvm.org/D18768
___
cfe-commits mai
aaron.ballman added a comment.
I had the chance to finalize this long-standing review by fixing up the
remaining test cases and removing the unused enumerators from AttributeList.h.
I've commit in r319002 (but cannot close the review because the "Accept" didn't
happen).
https://reviews.llvm.o
rsmith added a comment.
I think this is a reasonable direction. I'd like to see some kind of %list form
added to our diagnostics system, but I don't mind whether that happens before
or after this change.
(I'd also prefer to use singular forms in the various subject names, but that
seems to cre
aaron.ballman added a comment.
Ping
http://reviews.llvm.org/D18768
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman created this revision.
aaron.ballman added reviewers: rsmith, doug.gregor.
aaron.ballman added a subscriber: cfe-commits.
Currently, attribute subject lists attempt to automatically determine what
diagnostic to emit when the attribute does not appertain to a given
declaration. It d