Re: [PATCH] D18745: [clang-tidy] Adds misc-use-bool-literals check.

2016-04-04 Thread Piotr Padlewski via cfe-commits
Prazek added a comment. In http://reviews.llvm.org/D18745#390739, @Eugene.Zelenko wrote: > Isn't readability-implicit-bool-cast¶ should catch such issues? If not, I > think will be good idea to improve that check instead of introducing new one. I wouldn't add this functionality there. I see th

Re: [PATCH] D18745: [clang-tidy] Adds misc-use-bool-literals check.

2016-04-04 Thread Alexander Kornienko via cfe-commits
alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. 1. Looks like `modernize` would be a better fit for this check, since it targets a pattern common for pre-standard C++ (or C code). 2. Please clang-format the code. 3. Please run the

Re: [PATCH] D18745: [clang-tidy] Adds misc-use-bool-literals check.

2016-04-03 Thread Eugene Zelenko via cfe-commits
Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Isn't readability-implicit-bool-cast¶ should catch such issues? If not, I think will be good idea to improve that check instead of introducing new one. http://reviews.llvm.org/D18745 __