arsenm closed this revision.
arsenm added a comment.
r266383
http://reviews.llvm.org/D18473
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tstellarAMD accepted this revision.
This revision is now accepted and ready to land.
Comment at: lib/Basic/Targets.cpp:1854-1857
@@ -1853,1 +1853,6 @@
+ bool isCLZForZeroUndef() const override {
+// It is -1 instead of expected for intrinsic.
+return true;
+ }
+
--
arsenm added inline comments.
Comment at: lib/Basic/Targets.cpp:1854-1857
@@ -1853,1 +1853,6 @@
+ bool isCLZForZeroUndef() const override {
+// It is -1 instead of expected for intrinsic.
+return true;
+ }
+
tstellarAMD wrote:
> Why do we need to add t
tstellarAMD added inline comments.
Comment at: lib/Basic/Targets.cpp:1854-1857
@@ -1853,1 +1853,6 @@
+ bool isCLZForZeroUndef() const override {
+// It is -1 instead of expected for intrinsic.
+return true;
+ }
+
Why do we need to add this if it's the
arsenm created this revision.
arsenm added a reviewer: tstellarAMD.
arsenm added a subscriber: cfe-commits.
This is the same as the default implementation, but
add a comment and make sure the behavior is tested.
http://reviews.llvm.org/D18473
Files:
lib/Basic/Targets.cpp
test/CodeGenOpenCL/b
