rengolin closed this revision.
rengolin added a comment.
Committed in r263957.
http://reviews.llvm.org/D18311
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
samparker updated this revision to Diff 51173.
samparker added a comment.
Combined the two diffs
http://reviews.llvm.org/D18311
Files:
test/CodeGen/arm-target-features.c
test/Driver/arm-cortex-cpus.c
test/Preprocessor/arm-target-features.c
Index: test/Preprocessor/arm-target-features.c
=
rengolin added a comment.
Right, if you could update both reviews with the full patch, I could commit
them for you, for now.
http://reviews.llvm.org/D18311
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
samparker added a comment.
Hi Renato,
Thanks for the tips, one patch makes much more sense. I'm currently in the
process of obtaining commit access and this patch depends on
http://reviews.llvm.org/D18239.
Thanks again,
sam
http://reviews.llvm.org/D18311
__
rengolin accepted this revision.
rengolin added a reviewer: rengolin.
rengolin added a comment.
This revision is now accepted and ready to land.
Hi Sam,
The patch looks good, thanks!
A few comments on the process:
1. When you send an update, send the whole patch again, not just the new diff.
E
samparker updated this revision to Diff 51165.
samparker added a comment.
Changed A53-ARM and A53-THUMB test prefixes to ARMV8-ARM and ARMV8-THUMB.
http://reviews.llvm.org/D18311
Files:
test/Preprocessor/arm-target-features.c
Index: test/Preprocessor/arm-target-features.c
===
rengolin added inline comments.
Comment at: test/Preprocessor/arm-target-features.c:349
@@ -349,1 +348,3 @@
+// Test whether predefines are as expected when targeting ARMv8-A Cortex
implementations
+// RUN: %clang -target armv8 -mcpu=cortex-a32 -x c -E -dM %s -o - | FileCheck
--
samparker created this revision.
samparker added a subscriber: cfe-commits.
Herald added subscribers: rengolin, aemerson.
http://reviews.llvm.org/D18311
Files:
test/CodeGen/arm-target-features.c
test/Driver/arm-cortex-cpus.c
test/Preprocessor/arm-target-features.c
Index: test/Preprocessor/
