bruno closed this revision.
bruno added a comment.
Thanks Richard. Applied your last comments and committed in r264752
http://reviews.llvm.org/D18296
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
rsmith accepted this revision.
This revision is now accepted and ready to land.
Comment at: lib/Analysis/FormatString.cpp:276
@@ +275,3 @@
+ // UTF-8 sequence. If that's the case, adjust the length accordingly.
+ if (llvm::sys::locale::isPrint(FirstByte))
+return false;
bruno updated this revision to Diff 51859.
bruno added a comment.
Update after Richard's review.
- Handle scanf
- Properly update `ConversionSpecifier`
http://reviews.llvm.org/D18296
Files:
include/clang/Analysis/Analyses/FormatString.h
lib/Analysis/FormatString.cpp
lib/Analysis/FormatSt
bruno added a comment.
In http://reviews.llvm.org/D18296#384766, @rsmith wrote:
> This patch builds a length-1 `ConversionSpecifier` but includes the complete
> code point in the length of the overall format specifier, which is
> inconsistent. Please either treat the trailing bytes as part of t
rsmith added a comment.
This patch builds a length-1 `ConversionSpecifier` but includes the complete
code point in the length of the overall format specifier, which is
inconsistent. Please either treat the trailing bytes as part of the
`ConversionSpecifier` or revert the changes to `ParsePrintf
bruno added a comment.
Ping :-)
http://reviews.llvm.org/D18296
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno added a comment.
Ping!
http://reviews.llvm.org/D18296
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno created this revision.
bruno added a reviewer: rsmith.
bruno added subscribers: cfe-commits, dexonsmith.
Improve invalid format string specifier handling by printing out invalid
specifiers characters with \x, \u and \U. Previously clang would print gargabe
whenever the character is unprint
