arsenm closed this revision.
arsenm added a comment.
r272091
http://reviews.llvm.org/D17516
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
Seems pretty reasonable. If I missed anything we can pick it up later.
-eric
Comment at: lib/Basic/Targets.cpp:2010
@@ +2009,3 @@
+
+ // XXX - What does the member GPU m
arsenm added a comment.
ping
http://reviews.llvm.org/D17516
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arsenm updated this revision to Diff 51636.
arsenm added a comment.
Try to move more code into initFeatureMap.
I'm not sure how the booleans for features in the class are for now. X86 seems
to have them, but it seems they are only used with user specified features? The
only ones that matter rig
echristo added a comment.
Replied inline, I hope this is helpful :)
Comment at: lib/Basic/Targets.cpp:2059-2063
@@ +2058,7 @@
+
+ if (Has16BitInsts)
+Features["16-bit-insts"] = true;
+
+ if (hasSMemRealTime)
+Features["s-memrealtime"] = true;
+
arsenm
arsenm added inline comments.
Comment at: lib/Basic/Targets.cpp:2059-2063
@@ +2058,7 @@
+
+ if (Has16BitInsts)
+Features["16-bit-insts"] = true;
+
+ if (hasSMemRealTime)
+Features["s-memrealtime"] = true;
+
echristo wrote:
> This is typically more of the
echristo added inline comments.
Comment at: lib/Basic/Targets.cpp:1829
@@ -1820,2 +1828,3 @@
}
+
AddrSpaceMap = &AMDGPUAddrSpaceMap;
Extra whitespace.
Comment at: lib/Basic/Targets.cpp:2059-2063
@@ +2058,7 @@
+
+ if (Has16BitInsts)
+
arsenm created this revision.
arsenm added reviewers: tstellarAMD, echristo.
arsenm added a subscriber: cfe-commits.
Cleanup setup of subtarget features.
http://reviews.llvm.org/D17516
Files:
include/clang/Basic/BuiltinsAMDGPU.def
lib/Basic/Targets.cpp
test/CodeGenOpenCL/builtins-amdgcn-er
