Re: [PATCH] D17447: Add check for CERT ENV33-C

2016-02-22 Thread Aaron Ballman via cfe-commits
aaron.ballman closed this revision. aaron.ballman added a comment. Thanks! I've commit in r261530. http://reviews.llvm.org/D17447 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17447: Add check for CERT ENV33-C

2016-02-22 Thread Aaron Ballman via cfe-commits
aaron.ballman marked 4 inline comments as done. aaron.ballman added a comment. http://reviews.llvm.org/D17447 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17447: Add check for CERT ENV33-C

2016-02-22 Thread Aaron Ballman via cfe-commits
aaron.ballman updated this revision to Diff 48674. aaron.ballman added a comment. Updated based on review feedback. http://reviews.llvm.org/D17447 Files: clang-tidy/cert/CERTTidyModule.cpp clang-tidy/cert/CMakeLists.txt clang-tidy/cert/CommandProcessorCheck.cpp clang-tidy/cert/CommandPr

Re: [PATCH] D17447: Add check for CERT ENV33-C

2016-02-19 Thread Samuel Benzaquen via cfe-commits
sbenza added inline comments. Comment at: clang-tidy/cert/CommandProcessorCheck.cpp:36 @@ +35,3 @@ + // is not a security risk by itself. + if (Fn->getName() == "system" && E->getNumArgs() == 1 && + E->getArg(0)->isNullPointerConstant(*Result.Context, You c

Re: [PATCH] D17447: Add check for CERT ENV33-C

2016-02-19 Thread Aaron Ballman via cfe-commits
aaron.ballman added inline comments. Comment at: clang-tidy/cert/CommandProcessorCheck.cpp:22 @@ +21,3 @@ + Finder->addMatcher( + callExpr(callee(functionDecl(anyOf(hasName("system"), hasName("popen"), + hasName("_popen"))) ---

Re: [PATCH] D17447: Add check for CERT ENV33-C

2016-02-19 Thread Aaron Ballman via cfe-commits
aaron.ballman updated this revision to Diff 48499. aaron.ballman marked an inline comment as done. http://reviews.llvm.org/D17447 Files: clang-tidy/cert/CERTTidyModule.cpp clang-tidy/cert/CMakeLists.txt clang-tidy/cert/CommandProcessorCheck.cpp clang-tidy/cert/CommandProcessorCheck.h do

Re: [PATCH] D17447: Add check for CERT ENV33-C

2016-02-19 Thread Samuel Benzaquen via cfe-commits
sbenza added inline comments. Comment at: clang-tidy/cert/CommandProcessorCheck.cpp:22 @@ +21,3 @@ + Finder->addMatcher( + callExpr(callee(functionDecl(anyOf(hasName("system"), hasName("popen"), + hasName("_popen"))) S

[PATCH] D17447: Add check for CERT ENV33-C

2016-02-19 Thread Aaron Ballman via cfe-commits
aaron.ballman created this revision. aaron.ballman added reviewers: alexfh, sbenza. aaron.ballman added a subscriber: cfe-commits. This patch adds a check for the CERT secure coding rule: ENV33-C. Do not call system(). It flags any call expression that calls a system command processor (system(),