This revision was automatically updated to reflect the committed changes.
Closed by commit rL261309: ARM: fix VFP asm constraints (authored by jfb).
Changed prior to commit:
http://reviews.llvm.org/D17349?vs=48363&id=48453#toc
Repository:
rL LLVM
http://reviews.llvm.org/D17349
Files:
cfe/
compnerd accepted this revision.
compnerd added a reviewer: compnerd.
compnerd added a comment.
This revision is now accepted and ready to land.
Yeah, constraint validation is not one of the highlights of the current
implementation. This seems reasonable enough to merge I think.
http://reviews
jfb added a comment.
Is this ready to land? I'm hoping to get it into the 3.8 branch since it
affects musl libc's latest release.
http://reviews.llvm.org/D17349
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
jfb added a comment.
Added a test.
Constraint validation is lacking in LLVM: it doesn't check that the input
variable matches the constraint. I do pass `mfpmath vfp` to the test in case
this gets fixed, but it's not strictly necessary right now.
The following is currently accepted:
int oops
jfb updated this revision to Diff 48363.
jfb added a comment.
- Add test.
http://reviews.llvm.org/D17349
Files:
lib/Basic/Targets.cpp
test/CodeGen/arm-vfp-asm-constraint.c
Index: test/CodeGen/arm-vfp-asm-constraint.c
===
--- /
compnerd added a subscriber: compnerd.
compnerd added a comment.
Test cases? It seems that 't' and 'w' are not available in thumb-1 mode.
http://reviews.llvm.org/D17349
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
jfb added a comment.
As a reference, here's the GCC source (instead of the docs):
https://raw.githubusercontent.com/gcc-mirror/gcc/master/gcc/config/arm/constraints.md
http://reviews.llvm.org/D17349
___
cfe-commits mailing list
cfe-commits@lists.ll
jfb created this revision.
jfb added a subscriber: cfe-commits.
Herald added subscribers: rengolin, aemerson.
Rich Felker was sad that clang used 'w' and 'P' for VFP constraints when GCC
documents them as 't' and 'w':
https://gcc.gnu.org/onlinedocs/gcc/Machine-Constraints.html
This was added w
