Re: [PATCH] D17343: [OpenCL] Diagnose program scope pointers

2016-07-12 Thread Anastasia Stulova via cfe-commits
Anastasia abandoned this revision. Anastasia added a comment. After clarifying with Khronos, it doesn't seem like this is needed indeed! http://reviews.llvm.org/D17343 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi

Re: [PATCH] D17343: [OpenCL] Diagnose program scope pointers

2016-02-17 Thread Yaxun Liu via cfe-commits
yaxunl added a comment. I am not sure about the restriction that program scope pointer must point to global or constant addr space. Can you provide reference to the OpenCL 2.0 spec? https://www.khronos.org/registry/cl/specs/opencl-2.0-openclc.pdf On page 36 there are examples for program-scope

Re: [PATCH] D17343: [OpenCL] Diagnose program scope pointers

2016-02-17 Thread Mandeep Singh Grang via cfe-commits
mgrang added a subscriber: mgrang. Comment at: lib/Sema/SemaDecl.cpp:6605 @@ +6604,3 @@ + // Program scope pointers can only point to data at the constant or global + // address space. + const PointerType *PT = nullptr; Check alignment of comments

[PATCH] D17343: [OpenCL] Diagnose program scope pointers

2016-02-17 Thread Anastasia Stulova via cfe-commits
Anastasia created this revision. Anastasia added reviewers: pekka.jaaskelainen, yaxunl. Anastasia added a subscriber: cfe-commits. Programs scope pointers should point to objects in constant AS or for OpenCL 2.0 in global AS. http://reviews.llvm.org/D17343 Files: include/clang/Basic/Diagnosti