Re: [PATCH] D17146: [libcxx] locale portability refactor

2016-02-22 Thread Ben Craig via cfe-commits
bcraig abandoned this revision. bcraig added a comment. Breaking this up into smaller chunks. http://reviews.llvm.org/D17146 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17146: [libcxx] locale portability refactor

2016-02-11 Thread Ben Craig via cfe-commits
bcraig added a comment. In http://reviews.llvm.org/D17146#350382, @mclow.lists wrote: > > I'm open to recommendations on ways to test this that are better than > > "Submit, watch build bots, revert as necessary". > > > My suggestion is to do this incrementally. > Implement the infrastructure bi

Re: [PATCH] D17146: [libcxx] locale portability refactor

2016-02-11 Thread Marshall Clow via cfe-commits
mclow.lists added a comment. I am very much in favor of cleaning up this part of libc++. Thanks for taking this on. > I'm open to recommendations on ways to test this that are better than > "Submit, watch build bots, revert as necessary". My suggestion is to do this incrementally. Implement t