Re: [PATCH] D17130: Debloat some headers

2016-02-13 Thread Mehdi AMINI via cfe-commits
joker.eph added a subscriber: joker.eph. joker.eph added a comment. What the build time of clang before and after? (Your goal is to improve build time right?) http://reviews.llvm.org/D17130 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

Re: [PATCH] D17130: Debloat some headers

2016-02-11 Thread Alexander Riccio via cfe-commits
ariccio added a comment. In http://reviews.llvm.org/D17130#349744, @craig.topper wrote: > What's complex about the SVal constructors? I arbitrarily figured that classes that are more than twice-derived (is there a better way to say that) are complex. I don't think there was any //particularly

Re: [PATCH] D17130: Debloat some headers

2016-02-11 Thread Alexander Riccio via cfe-commits
ariccio added inline comments. Comment at: llvm/tools/clang/include/clang/StaticAnalyzer/Core/PathSensitive/CoreEngine.h:143 @@ -144,3 +142,3 @@ void addAbortedBlock(const ExplodedNode *node, const CFGBlock *block) { -blocksAborted.push_back(std::make_pair(block, node)); +

Re: [PATCH] D17130: Debloat some headers

2016-02-11 Thread Alexander Riccio via cfe-commits
ariccio updated the summary for this revision. ariccio updated this revision to Diff 47603. http://reviews.llvm.org/D17130 Files: llvm/tools/clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h llvm/tools/clang/include/clang/StaticAnalyzer/Core/CheckerManager.h llvm/tools/clang

Re: [PATCH] D17130: Debloat some headers

2016-02-10 Thread Craig Topper via cfe-commits
craig.topper added a subscriber: craig.topper. craig.topper added a comment. What's complex about the SVal constructors? Comment at: llvm/tools/clang/include/clang/StaticAnalyzer/Core/PathSensitive/CoreEngine.h:143 @@ -144,3 +142,3 @@ void addAbortedBlock(const ExplodedNode

[PATCH] D17130: Debloat some headers

2016-02-10 Thread Alexander Riccio via cfe-commits
ariccio created this revision. ariccio added a subscriber: cfe-commits. As discussed in "Code in headers" on llvm-dev, there are lots of headers with complex code in them. I've moved some complex constructors & destructors to implementation files, using [[ https://www.chromium.org/developers/co