Re: [PATCH] D17051: Get rid of CHECK-SAME-NOT in tests.

2016-02-09 Thread Justin Lebar via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL260334: Get rid of CHECK-SAME-NOT in tests. (authored by jlebar). Changed prior to commit: http://reviews.llvm.org/D17051?vs=47385&id=47397#toc Repository: rL LLVM http://reviews.llvm.org/D17051 Fi

Re: [PATCH] D17051: Get rid of CHECK-SAME-NOT in tests.

2016-02-09 Thread Justin Lebar via cfe-commits
jlebar marked 2 inline comments as done. Comment at: test/Modules/ModuleDebugInfo.cpp:10 @@ -9,3 +9,3 @@ // RUN: cat %t-mod.ll | FileCheck %s // RUN: cat %t-mod.ll | FileCheck --check-prefix=CHECK-NEG %s jroelofs wrote: > jlebar wrote: > > jlebar wrote: > > >

Re: [PATCH] D17051: Get rid of CHECK-SAME-NOT in tests.

2016-02-09 Thread Jonathan Roelofs via cfe-commits
jroelofs accepted this revision. jroelofs added a reviewer: jroelofs. jroelofs added a comment. This revision is now accepted and ready to land. LGTM. Comment at: test/Modules/ModuleDebugInfo.cpp:10 @@ -9,3 +9,3 @@ // RUN: cat %t-mod.ll | FileCheck %s // RUN: cat %t-mod.ll | F

Re: [PATCH] D17051: Get rid of CHECK-SAME-NOT in tests.

2016-02-09 Thread Justin Lebar via cfe-commits
jlebar marked 3 inline comments as done. Comment at: test/Modules/ModuleDebugInfo.cpp:10 @@ -9,3 +9,3 @@ // RUN: cat %t-mod.ll | FileCheck %s // RUN: cat %t-mod.ll | FileCheck --check-prefix=CHECK-NEG %s jlebar wrote: > jlebar wrote: > > jroelofs wrote: > > >

Re: [PATCH] D17051: Get rid of CHECK-SAME-NOT in tests.

2016-02-09 Thread Jonathan Roelofs via cfe-commits
jroelofs added inline comments. Comment at: test/Modules/ModuleDebugInfo.cpp:25 @@ -25,1 +24,3 @@ +// CHECK-SAME:dwoId: +// CHECK-SAME:) jlebar wrote: > jroelofs wrote: > > This `CHECK-SAME` line and all the others are sti

Re: [PATCH] D17051: Get rid of CHECK-SAME-NOT in tests.

2016-02-09 Thread Justin Lebar via cfe-commits
jlebar marked an inline comment as done. Comment at: test/Modules/ModuleDebugInfo.cpp:10 @@ -9,3 +9,3 @@ // RUN: cat %t-mod.ll | FileCheck %s // RUN: cat %t-mod.ll | FileCheck --check-prefix=CHECK-NEG %s jlebar wrote: > jroelofs wrote: > > While you're here, m

Re: [PATCH] D17051: Get rid of CHECK-SAME-NOT in tests.

2016-02-09 Thread Justin Lebar via cfe-commits
jlebar added inline comments. Comment at: test/Modules/ModuleDebugInfo.cpp:10 @@ -9,3 +9,3 @@ // RUN: cat %t-mod.ll | FileCheck %s // RUN: cat %t-mod.ll | FileCheck --check-prefix=CHECK-NEG %s jroelofs wrote: > While you're here, may as well shorten these thre

Re: [PATCH] D17051: Get rid of CHECK-SAME-NOT in tests.

2016-02-09 Thread Jonathan Roelofs via cfe-commits
jroelofs added a subscriber: jroelofs. Comment at: test/Modules/ModuleDebugInfo.cpp:10 @@ -9,3 +9,3 @@ // RUN: cat %t-mod.ll | FileCheck %s // RUN: cat %t-mod.ll | FileCheck --check-prefix=CHECK-NEG %s While you're here, may as well shorten these three lines t

[PATCH] D17051: Get rid of CHECK-SAME-NOT in tests.

2016-02-09 Thread Justin Lebar via cfe-commits
jlebar created this revision. jlebar added a reviewer: majnemer. jlebar added a subscriber: cfe-commits. This isn't a FileCheck directive; it does nothing. http://reviews.llvm.org/D17051 Files: test/CodeGenCXX/optnone-and-attributes.cpp test/CodeGenCXX/optnone-class-members.cpp test/CodeGe