Re: [PATCH] D17002: [lanai] Add Lanai backend to clang driver

2016-03-28 Thread Jacques Pienaar via cfe-commits
This revision was automatically updated to reflect the committed changes. jpienaar marked an inline comment as done. Closed by commit rL264655: [lanai] Add Lanai backend to clang driver. (authored by jpienaar). Changed prior to commit: http://reviews.llvm.org/D17002?vs=51806&id=51838#toc Repos

Re: [PATCH] D17002: [lanai] Add Lanai backend to clang driver

2016-03-28 Thread Eric Christopher via cfe-commits
echristo added a subscriber: echristo. echristo accepted this revision. echristo added a reviewer: echristo. echristo added a comment. LGTM, thanks. -eric http://reviews.llvm.org/D17002 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http:/

Re: [PATCH] D17002: [lanai] Add Lanai backend to clang driver

2016-03-28 Thread Chandler Carruth via cfe-commits
chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. LGTM with the comments from David addressed and the comment below addressed. Comment at: lib/Basic/Targets.cpp:6000-6001 @@ +5999,4 @@ + break; +default: +

Re: [PATCH] D17002: [lanai] Add Lanai backend to clang driver

2016-03-28 Thread Jacques Pienaar via cfe-commits
jpienaar added a comment. Updated, thanks Comment at: lib/CodeGen/TargetInfo.cpp:6622-6626 @@ +6621,7 @@ + + if (const BuiltinType *BT = T->getAs()) { +BuiltinType::Kind K = BT->getKind(); +if (K == BuiltinType::Float || K == BuiltinType::Double) + return Float; +

Re: [PATCH] D17002: [lanai] Add Lanai backend to clang driver

2016-03-28 Thread Jacques Pienaar via cfe-commits
jpienaar updated this revision to Diff 51806. jpienaar marked 6 inline comments as done. jpienaar added a comment. Removed unnecessary floating point classification (only integer is supported) and performed suggested cleanups. http://reviews.llvm.org/D17002 Files: lib/Basic/Targets.cpp lib

Re: [PATCH] D17002: [lanai] Add Lanai backend to clang driver

2016-03-28 Thread David Majnemer via cfe-commits
majnemer added a subscriber: majnemer. Comment at: lib/CodeGen/TargetInfo.cpp:6592-6594 @@ +6591,5 @@ + + static bool isRegisterSize(unsigned Size) { +return (Size == 8 || Size == 16 || Size == 32); + } + Is this used? A quick grep didn't find any callers.

Re: [PATCH] D17002: [lanai] Add Lanai backend to clang driver

2016-03-28 Thread Jacques Pienaar via cfe-commits
jpienaar added a comment. Friendly ping. http://reviews.llvm.org/D17002 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17002: [lanai] Add Lanai backend to clang driver

2016-03-07 Thread Jacques Pienaar via cfe-commits
jpienaar updated this revision to Diff 49969. jpienaar added a comment. Updated to use resetDataLayout. http://reviews.llvm.org/D17002 Files: lib/Basic/Targets.cpp lib/CodeGen/TargetInfo.cpp lib/Driver/Driver.cpp lib/Driver/ToolChains.h lib/Driver/Tools.cpp lib/Driver/Tools.h test

Re: [PATCH] D17002: [lanai] Add Lanai backend to clang driver

2016-03-02 Thread Jacques Pienaar via cfe-commits
jpienaar updated this revision to Diff 49688. jpienaar added a comment. Removed unused variables in LanaiTargetInfo. http://reviews.llvm.org/D17002 Files: lib/Basic/Targets.cpp lib/CodeGen/TargetInfo.cpp lib/Driver/Driver.cpp lib/Driver/ToolChains.h lib/Driver/Tools.cpp lib/Driver/T

Re: [PATCH] D17002: [lanai] Add Lanai backend to clang driver

2016-02-25 Thread Jacques Pienaar via cfe-commits
jpienaar added reviewers: eliben, jyknight, chandlerc. jpienaar updated this revision to Diff 49119. jpienaar added a comment. Updated preprocessor test init.c to use -match-full-lines. http://reviews.llvm.org/D17002 Files: lib/Basic/Targets.cpp lib/CodeGen/TargetInfo.cpp lib/Driver/Drive

Re: [PATCH] D17002: [lanai] Add Lanai backend to clang driver

2016-02-16 Thread Jacques Pienaar via cfe-commits
jpienaar added inline comments. Comment at: test/CodeGen/lanai-arguments.c:1 @@ +1,2 @@ +// RUN: %clang_cc1 -triple wasm32-unknown-unknown %s -emit-llvm -o - \ +// RUN: | FileCheck %s -check-prefix=LANAI eliben wrote: > why wasm triple? Fixed, thanks. http://r

Re: [PATCH] D17002: [lanai] Add Lanai backend to clang driver

2016-02-16 Thread Jacques Pienaar via cfe-commits
jpienaar updated the summary for this revision. jpienaar updated this revision to Diff 48119. jpienaar marked an inline comment as done. jpienaar added a comment. Herald added a subscriber: joker.eph. Move mregparm check to Tools.cpp and correct triple used in test. http://reviews.llvm.org/D1700

Re: [PATCH] D17002: [lanai] Add Lanai backend to clang driver

2016-02-16 Thread Eli Bendersky via cfe-commits
eliben added inline comments. Comment at: lib/CodeGen/TargetInfo.cpp:6498 @@ +6497,3 @@ + + Class classify(QualType Ty) const; + jpienaar wrote: > We only had one DefaultNumRegisterParameters that we supported > (DefaultNumRegisterParameters=4) so I just propaga

Re: [PATCH] D17002: [lanai] Add Lanai backend to clang driver

2016-02-09 Thread Jacques Pienaar via cfe-commits
jpienaar marked 3 inline comments as done. jpienaar added a comment. Updated thanks. Comment at: lib/CodeGen/TargetInfo.cpp:6498 @@ +6497,3 @@ + + Class classify(QualType Ty) const; + We only had one DefaultNumRegisterParameters that we supported (DefaultNumRe

Re: [PATCH] D17002: [lanai] Add Lanai backend to clang driver

2016-02-09 Thread Jacques Pienaar via cfe-commits
jpienaar updated this revision to Diff 47408. jpienaar added a comment. Added clang-level tests. http://reviews.llvm.org/D17002 Files: lib/Basic/Targets.cpp lib/CodeGen/TargetInfo.cpp lib/Driver/Driver.cpp lib/Driver/ToolChains.h lib/Driver/Tools.cpp lib/Driver/Tools.h test/CodeGe

Re: [PATCH] D17002: [lanai] Add Lanai backend to clang driver

2016-02-09 Thread Eli Bendersky via cfe-commits
eliben added a subscriber: eliben. eliben added a comment. Clang-level tests? Comment at: lib/Basic/Targets.cpp:5873 @@ +5872,3 @@ +"-m:e" // ELF name manging +"-p:32:32" // 32-bit pointers work aligned +"-i64:64" // 64 bit integers, 64 bit aligne