Re: [PATCH] D16971: Fixed crash when partial specialization is missing required parameters

2016-02-10 Thread don hinton via cfe-commits
hintonda added a comment. I don't have commit access, so if this patch is accepted, could someone please commit it for me? http://reviews.llvm.org/D16971 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

Re: [PATCH] D16971: Fixed crash when partial specialization is missing required parameters

2016-02-10 Thread don hinton via cfe-commits
hintonda updated this revision to Diff 47499. hintonda added a comment. - Added test for PR26077 http://reviews.llvm.org/D16971 Files: lib/Sema/SemaTemplate.cpp test/SemaCXX/pr26077-crash-on-invalid.cpp Index: test/SemaCXX/pr26077-crash-on-invalid.cpp ==

Re: [PATCH] D16971: Fixed crash when partial specialization is missing required parameters

2016-02-09 Thread don hinton via cfe-commits
hintonda added a comment. This patch fixes bug 26077. https://llvm.org/bugs/show_bug.cgi?id=26077 http://reviews.llvm.org/D16971 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16971: Fixed crash when partial specialization is missing required parameters

2016-02-07 Thread don hinton via cfe-commits
hintonda added a comment. Here's a snippet of code that will crash: lass DB {}; template class RemovePolicy : public T {}; template > class Crash : T, Policy {}; template class Crash : public DB, public Policy { public: Crash(){} }; http://reviews.llvm.org/D16971

[PATCH] D16971: Fixed crash when partial specialization is missing required parameters

2016-02-07 Thread don hinton via cfe-commits
hintonda created this revision. hintonda added reviewers: doug.gregor, lvoufo. hintonda added a subscriber: cfe-commits. The code sets isPartialSpecialization = false instead of returning true, which will cause a crash later when the missing template parameter is referenced. http://reviews.llvm.