rsmith closed this revision.
rsmith added a comment.
Committed as r261034.
http://reviews.llvm.org/D16930
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
erik.pilkington added a comment.
Yes I do, if you don't mind. Thanks for your help!
http://reviews.llvm.org/D16930
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Looks great, thanks, do you need someone to commit this for you?
http://reviews.llvm.org/D16930
___
cfe-commits mailing list
cfe-commits@lists.ll
erik.pilkington updated this revision to Diff 47246.
erik.pilkington added a comment.
Remove the FinishedParams label, clean up the control flow.
http://reviews.llvm.org/D16930
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDeclCXX.cpp
test/CXX/over/over.oper/over.literal/
rsmith added a comment.
Thanks, this looks good. I think we can make the control flow a little more
obvious by moving the `return true;`s right after we emit each diagnostic, and
that also lets us remove the `goto`.
Comment at: lib/Sema/SemaDeclCXX.cpp:11769
@@ +11768,3 @@
+st
erik.pilkington updated this revision to Diff 47240.
erik.pilkington added a comment.
Thanks! This update fixes everything you brought up.
http://reviews.llvm.org/D16930
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDeclCXX.cpp
test/CXX/over/over.oper/over.literal/p5.cpp
rsmith added a comment.
Thanks for tackling this!
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:6889
@@ +6888,3 @@
+def err_literal_operator_invalid_param : Error<
+ "invalid literal operator parameter type %0">;
+def err_literal_operator_param : Error<
---
erik.pilkington created this revision.
erik.pilkington added a reviewer: rsmith.
erik.pilkington added a subscriber: cfe-commits.
Previously, invalid parameters in a literal operator function were diagnosed
with an uninformative catch all. This commit breaks the catch all into a couple
of more i
