Re: [PATCH] D16929: add support for -print-imm-hex for AArch64

2016-02-16 Thread James Molloy via cfe-commits
jmolloy accepted this revision. jmolloy added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rL LLVM http://reviews.llvm.org/D16929 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.o

Re: [PATCH] D16929: add support for -print-imm-hex for AArch64

2016-02-16 Thread Paul Osmialowski via cfe-commits
pawosm01 added a comment. You're right, this patch smuggles elimination of two dead functions. I've prepared alternative version of this patch which does not do that. Repository: rL LLVM http://reviews.llvm.org/D16929 ___ cfe-commits mailing lis

Re: [PATCH] D16929: add support for -print-imm-hex for AArch64

2016-02-15 Thread James Molloy via cfe-commits
jmolloy added a comment. Hi Pawel, Thanks for this - it generally looks good to me. Just one comment. James Comment at: lib/Target/AArch64/InstPrinter/AArch64InstPrinter.h:107 @@ -106,3 @@ - template - void printAMIndexedWB(const MCInst *MI, unsigned OpNum, -