[PATCH] D16761: clang-cl: Support loading plugins on Windows

2019-03-25 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. Clang's plugin model is currently fundamentally incompatible with how imports and exports work on Windows, which I'm guessing is probably why LLVM_EXPORT_REGISTRY was removed as well. There's no easy way to get plugins to work on Windows. CHANGES SINCE LAST ACTION ht

[PATCH] D16761: clang-cl: Support loading plugins on Windows

2019-03-25 Thread Vassil Vassilev via Phabricator via cfe-commits
v.g.vassilev added a comment. Indeed. IIUC, here is no way clang-cl to load plugins if compiled BUILD_SHARED_LIB=0. It is not clear to me if that's a design limitation or something else. I'd love to be able to load plugins on a 'standard' clang-cl instance. CHANGES SINCE LAST ACTION https:/

[PATCH] D16761: clang-cl: Support loading plugins on Windows

2019-03-24 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. LLVM_EXPORT_REGISTRY no longer exists, so this can't be relanded. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D16761/new/ https://reviews.llvm.org/D16761 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D16761: clang-cl: Support loading plugins on Windows

2019-03-24 Thread NAKAMURA Takumi via Phabricator via cfe-commits
chapuni added a comment. @v.g.vassilev, I couldn't explain what it caused. Fell free to recommit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D16761/new/ https://reviews.llvm.org/D16761 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D16761: clang-cl: Support loading plugins on Windows

2019-03-24 Thread Vassil Vassilev via Phabricator via cfe-commits
v.g.vassilev added subscribers: chapuni, v.g.vassilev. v.g.vassilev added a comment. @chapuni, you have reverted this patch and the commit message says "investigating". Did you come to a conclusion? Can we reland it? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D16761/new/ https://revi

Re: [PATCH] D16761: clang-cl: Support loading plugins on Windows

2016-09-26 Thread Eugene Zelenko via cfe-commits
Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Was committed in r260265, but reverted in r260536. https://reviews.llvm.org/D16761 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-b

Re: [PATCH] D16761: clang-cl: Support loading plugins on Windows

2016-02-08 Thread Reid Kleckner via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm http://reviews.llvm.org/D16761 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16761: clang-cl: Support loading plugins on Windows

2016-02-05 Thread Ehsan Akhgari via cfe-commits
ehsan updated this revision to Diff 47057. ehsan added a comment. Sorry for the noise, arconist fail... http://reviews.llvm.org/D16761 Files: docs/ClangPlugins.rst examples/PrintFunctionNames/PrintFunctionNames.cpp lib/FrontendTool/ExecuteCompilerInvocation.cpp test/Frontend/plugins.c

Re: [PATCH] D16761: clang-cl: Support loading plugins on Windows

2016-02-05 Thread Ehsan Akhgari via cfe-commits
ehsan updated this revision to Diff 47056. ehsan added a comment. Updating based on the LLVM side changes. http://reviews.llvm.org/D16761 Files: docs/ClangPlugins.rst examples/PrintFunctionNames/PrintFunctionNames.cpp include/clang/Basic/DiagnosticASTKinds.td lib/AST/ExprConstant.cpp

[PATCH] D16761: clang-cl: Support loading plugins on Windows

2016-01-31 Thread Ehsan Akhgari via cfe-commits
ehsan created this revision. ehsan added a reviewer: rnk. ehsan added a subscriber: cfe-commits. This builds on the support being added to LLVM to import and export registries from DLLs. This will allow us to pick up the registry entries added in the DLL's copy of FrontendPluginRegistry. This wi