Re: [PATCH] D16552: Implement the likely resolution of core issue 253.

thakis closed this revision. thakis added a comment. Thanks! Landed the cxx_dr_status.html update in r261295 and this change in r261297. http://reviews.llvm.org/D16552 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

Re: [PATCH] D16552: Implement the likely resolution of core issue 253.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Thanks, LGTM! If it's convenient, it'd be nice to check in a new cxx_dr_status.html without your change first, as a separate commit, so it's more obvious which parts of the file are changed b

Re: [PATCH] D16552: Implement the likely resolution of core issue 253.

thakis updated this revision to Diff 48418. thakis added a comment. Thanks! All done. http://reviews.llvm.org/D16552 Files: include/clang/AST/DeclCXX.h lib/AST/ASTImporter.cpp lib/AST/DeclCXX.cpp lib/Sema/SemaInit.cpp lib/Serialization/ASTReaderDecl.cpp lib/Serialization/ASTWriter.c

Re: [PATCH] D16552: Implement the likely resolution of core issue 253.

rsmith added inline comments. Comment at: lib/AST/DeclCXX.cpp:396-425 @@ -394,1 +395,32 @@ +bool CXXRecordDecl::allowConstDefaultInitSlow() const { + assert(getDefinition() && "only call this on completed records"); + if (hasUserProvidedDefaultConstructor()) { +data().setA

Re: [PATCH] D16552: Implement the likely resolution of core issue 253.

thakis updated this revision to Diff 48376. thakis added a comment. update test http://reviews.llvm.org/D16552 Files: include/clang/AST/DeclCXX.h lib/AST/ASTImporter.cpp lib/AST/DeclCXX.cpp lib/Sema/SemaInit.cpp lib/Serialization/ASTReaderDecl.cpp lib/Serialization/ASTWriter.cpp t

Re: [PATCH] D16552: Implement the likely resolution of core issue 253.

thakis added inline comments. Comment at: lib/AST/DeclCXX.cpp:403-413 @@ +402,13 @@ + for (const auto *F : fields()) { +if (F->hasInClassInitializer() || F->isMutable() || F->isUnnamedBitfield()) + continue; +if (CXXRecordDecl *FieldType = F->getType()->getAsCXXRecor

Re: [PATCH] D16552: Implement the likely resolution of core issue 253.

thakis added a comment. thanks! Comment at: include/clang/AST/DeclCXX.h:405-416 @@ -404,1 +404,14 @@ +enum AllowConstDefInitKind { + ACDI_Unknown, + ACDI_Yes, + ACDI_No, +}; +unsigned AllowConstDefaultInit : 3; +AllowConstDefInitKind allowCons

Re: [PATCH] D16552: Implement the likely resolution of core issue 253.

thakis updated this revision to Diff 48373. thakis marked an inline comment as done. thakis added a comment. address comments http://reviews.llvm.org/D16552 Files: include/clang/AST/DeclCXX.h lib/AST/ASTImporter.cpp lib/AST/DeclCXX.cpp lib/Sema/SemaInit.cpp lib/Serialization/ASTReader

Re: [PATCH] D16552: Implement the likely resolution of core issue 253.

rsmith added inline comments. Comment at: include/clang/AST/DeclCXX.h:405-416 @@ -404,1 +404,14 @@ +enum AllowConstDefInitKind { + ACDI_Unknown, + ACDI_Yes, + ACDI_No, +}; +unsigned AllowConstDefaultInit : 3; +AllowConstDefInitKind allowConstDef

Re: [PATCH] D16552: Implement the likely resolution of core issue 253.

thakis added inline comments. Comment at: include/clang/AST/DeclCXX.h:410 @@ +409,3 @@ +}; +unsigned AllowConstDefaultInit : 3; +AllowConstDefInitKind allowConstDefInitKind() { This should be :2 of course. http://reviews.llvm.org/D16552 __

Re: [PATCH] D16552: Implement the likely resolution of core issue 253.

thakis updated this revision to Diff 48248. thakis added a comment. Ok, now cleaned up and caches the "is this ok?" state on a per-record level. http://reviews.llvm.org/D16552 Files: include/clang/AST/DeclCXX.h lib/AST/ASTImporter.cpp lib/AST/DeclCXX.cpp lib/Sema/SemaInit.cpp lib/Seri