Re: [PATCH] D16538: [cc1as] Add MCTargetOptions argument to createAsmBackend

2016-07-25 Thread Joel Jones via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL276655: [cc1as] Add MCTargetOptions argument to createAsmBackend (authored by joel_k_jones). Changed prior to commit: https://reviews.llvm.org/D16538?vs=62793&id=65374#toc Repository: rL LLVM https:

Re: [PATCH] D16538: [cc1as] Add MCTargetOptions argument to createAsmBackend

2016-07-19 Thread Joel Jones via cfe-commits
joelkevinjones added a comment. Ping. This change needs to be made once https://reviews.llvm.org/D16213 goes in. https://reviews.llvm.org/D16538 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

Re: [PATCH] D16538: [cc1as] Add MCTargetOptions argument to createAsmBackend

2016-07-05 Thread Joel Jones via cfe-commits
joelkevinjones updated this revision to Diff 62793. joelkevinjones added a comment. Herald added a subscriber: mehdi_amini. Updated to ToT. Passes "make check-clang" http://reviews.llvm.org/D16538 Files: tools/driver/cc1as_main.cpp Index: tools/driver/cc1as_main.cpp =

Re: [PATCH] D16538: [cc1as] Add MCTargetOptions argument to createAsmBackend

2016-03-11 Thread Evgeniy Stepanov via cfe-commits
eugenis added inline comments. Comment at: tools/driver/cc1as_main.cpp:413-416 @@ -412,6 +414,6 @@ // FIXME: init MCTargetOptions from sanitizer flags here. MCTargetOptions Options; std::unique_ptr TAP( TheTarget->createMCAsmParser(*STI, *Parser, *MCII, Options))

Re: [PATCH] D16538: [cc1as] Add MCTargetOptions argument to createAsmBackend

2016-03-11 Thread Daniel Sanders via cfe-commits
dsanders added subscribers: eugenis, ygorshenin. dsanders added a comment. I think it refers to MCTargetOptions::SanitizeAddress but I don't know where we'd get that information from. Unfortunately, it seems that the original author (@ygorshenin) might not be on the list anymore (phabricator sho

Re: [PATCH] D16538: [cc1as] Add MCTargetOptions argument to createAsmBackend

2016-02-26 Thread Joel Jones via cfe-commits
joelkevinjones added a comment. The FIXME comment doesn't make sense to me. I'm not sure what sanitizer arguments would be passed to the assembler. http://reviews.llvm.org/D16538 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.

Re: [PATCH] D16538: [cc1as] Add MCTargetOptions argument to createAsmBackend

2016-02-04 Thread Joel Jones via cfe-commits
joelkevinjones added a comment. Ping. http://reviews.llvm.org/D16538 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16538: [cc1as] Add MCTargetOptions argument to createAsmBackend

2016-02-04 Thread Eric Christopher via cfe-commits
echristo added a comment. In http://reviews.llvm.org/D16538#344540, @joelkevinjones wrote: > Ping. The FIXME at cc1as_main.cpp:413 http://reviews.llvm.org/D16538 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

Re: [PATCH] D16538: [cc1as] Add MCTargetOptions argument to createAsmBackend

2016-01-28 Thread Joel Jones via cfe-commits
joelkevinjones added a comment. Did you mean remove the duplication from addPassesToEmitFile mentioned in the FIXME or something else? http://reviews.llvm.org/D16538 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-

Re: [PATCH] D16538: [cc1as] Add MCTargetOptions argument to createAsmBackend

2016-01-27 Thread Eric Christopher via cfe-commits
echristo added a comment. Hi Joel, Since you're likely going to need to start filling in the Options there anyhow, can you lift the one from the TODO and start filling it in? -eric http://reviews.llvm.org/D16538 ___ cfe-commits mailing list cfe-c