Re: [PATCH] D16503: [MSVC Compat] Warn when suppressing a trailing comma in macro args

2016-02-02 Thread Ehsan Akhgari via cfe-commits
ehsan added a comment. In http://reviews.llvm.org/D16503#342116, @thakis wrote: > Sorry for the slow response. I was reading http://reviews.llvm.org/D15670 to > understand this patch, and I couldn't find anything in that patch that > enables this extension only in Microsoft mode. Trying > supp

Re: [PATCH] D16503: [MSVC Compat] Warn when suppressing a trailing comma in macro args

2016-02-02 Thread Nico Weber via cfe-commits
thakis added a comment. Sorry for the slow response. I was reading http://reviews.llvm.org/D15670 to understand this patch, and I couldn't find anything in that patch that enables this extension only in Microsoft mode. Trying suppressed-comma-msextension.cpp locally, it seems to pass without -f

[PATCH] D16503: [MSVC Compat] Warn when suppressing a trailing comma in macro args

2016-01-22 Thread Ehsan Akhgari via cfe-commits
ehsan created this revision. ehsan added a reviewer: thakis. ehsan added a subscriber: cfe-commits. MSVC suppresses a trailing comma if no arguments are passed in place of a variadic argument[1]. This patch adds a -Wmicrosoft warning when accepting such code. [1] https://msdn.microsoft.com/en-us