Re: [PATCH] D16502: [CUDA] Reject the alias attribute in CUDA device code.

2016-01-23 Thread Justin Lebar via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL258641: [CUDA] Reject the alias attribute in CUDA device code. (authored by jlebar). Changed prior to commit: http://reviews.llvm.org/D16502?vs=45783&id=45809#toc Repository: rL LLVM http://reviews.

Re: [PATCH] D16502: [CUDA] Reject the alias attribute in CUDA device code.

2016-01-23 Thread Justin Lebar via cfe-commits
jlebar added inline comments. Comment at: test/SemaCUDA/alias.cu:1-2 @@ +1,3 @@ +// REQUIRES: x86-registered-target +// REQUIRES: nvptx-registered-target +// RUN: %clang_cc1 -triple nvptx-unknown-cuda -fsyntax-only -fcuda-is-device -verify -DEXPECT_ERR %s jlebar

Re: [PATCH] D16502: [CUDA] Reject the alias attribute in CUDA device code.

2016-01-23 Thread Justin Lebar via cfe-commits
jlebar added inline comments. Comment at: test/SemaCUDA/alias.cu:1-2 @@ +1,3 @@ +// REQUIRES: x86-registered-target +// REQUIRES: nvptx-registered-target +// RUN: %clang_cc1 -triple nvptx-unknown-cuda -fsyntax-only -fcuda-is-device -verify -DEXPECT_ERR %s echrist

Re: [PATCH] D16502: [CUDA] Reject the alias attribute in CUDA device code.

2016-01-23 Thread Eric Christopher via cfe-commits
echristo accepted this revision. echristo added a reviewer: echristo. echristo added a comment. This revision is now accepted and ready to land. OK. One question inline, but feel free to commit after answering one way or the other :) -eric Comment at: test/SemaCUDA/alias.cu:1-

Re: [PATCH] D16502: [CUDA] Reject the alias attribute in CUDA device code.

2016-01-23 Thread Eric Christopher via cfe-commits
OK. -eric On Fri, Jan 22, 2016 at 5:56 PM Justin Lebar wrote: > jlebar created this revision. > jlebar added a reviewer: tra. > jlebar added subscribers: echristo, jhen, cfe-commits. > > CUDA (well, strictly speaking, NVPTX) doesn't support aliases. > > http://reviews.llvm.org/D16502 > > Files:

[PATCH] D16502: [CUDA] Reject the alias attribute in CUDA device code.

2016-01-22 Thread Justin Lebar via cfe-commits
jlebar created this revision. jlebar added a reviewer: tra. jlebar added subscribers: echristo, jhen, cfe-commits. CUDA (well, strictly speaking, NVPTX) doesn't support aliases. http://reviews.llvm.org/D16502 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaDeclAttr.cpp test/